[zuul] use 'service-telemetry' as namespace #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format was incorrect, and cannot include '#' or capital letters.
leifmadsen
reviewed
Sep 29, 2023
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| namespace: "service-telemetry-PR#{{ zuul.change }}-{{ zuul.build }}" | |||
| namespace: "service-telemetry" | |||
There was a problem hiding this comment.
Can you not just remove the # part and add a | lower function here? I'd still rather not lose the non-default namespace test.
There was a problem hiding this comment.
That would also cause a failure, because there are a few more places to shake out that don't use the namespace var.
There was a problem hiding this comment.
I'll reluctantly approve this to get things working, but can you file a follow up task to come back and make sure we can test with dynamic namespaces?
There was a problem hiding this comment.
I've created an issue to track this internally
leifmadsen
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format was incorrect, and cannot include '#' or capital letters.
https://review.rdoproject.org/zuul/build/7b4f5f48368a41d2be73044bbd00abed