Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zuul] use 'service-telemetry' as namespace #497

Merged
merged 2 commits into from
Sep 29, 2023
Merged

[zuul] use 'service-telemetry' as namespace #497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
881ccdc
[zuul] use 'service-telemetry' as namespace
elfiesmelfie Sep 29, 2023
7475a79
Merge branch 'master' into efoley-zuul-fix-namespace
elfiesmelfie Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/vars-zuul-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
namespace: "service-telemetry-PR#{{ zuul.change }}-{{ zuul.build }}"
namespace: "service-telemetry"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not just remove the # part and add a | lower function here? I'd still rather not lose the non-default namespace test.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would also cause a failure, because there are a few more places to shake out that don't use the namespace var.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reluctantly approve this to get things working, but can you file a follow up task to come back and make sure we can test with dynamic namespaces?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue to track this internally

setup_bundle_registry_tls_ca: false
setup_bundle_registry_auth: false
base_dir: "{{ sto_dir }}/build"
Expand Down