-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster Observability Operator dependency #504
Conversation
Add cluster observability operator as the preferred dependency (bottom of list is highest priority) when installing Service Telemetry Operator. The cluster-observability-operator is the name of the downstream (product) bundle in the Red Hat Operators CatalogSource. If installing for upstream, preferred operator will be observability-operator (when the Red Hat Operators CatalogSource is not available or enabled). And then as a fall-back method when neither Observability Operator or Cluster Observability Operator is not available, allow for Prometheus Operator from the Community Operators to satisfy for the Prometheus storage backend.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7f6f84507588435c8eaf691f282906f6 ✔️ stf-crc-latest-nightly_bundles SUCCESS in 17m 47s |
recheck |
@@ -39,3 +39,6 @@ properties: | |||
- package: | |||
packageName: observability-operator | |||
versionRange: '>=0.0.1' | |||
- package: | |||
packageName: cluster-observability-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same thing, right? observability-operator
is renaming to cluster-observability-operator
? Do we have any idea what happens if you've already installed it under the old name? I suppose we never released a version with the old name in place, so downstream customers at least would never be in this situation. Does that mean we can can/should remove the observability-operator
version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically the downstream (Red Hat Operators CatalogSource) will ship observability-operator as cluster-observability-operator. If you didn't have Red Hat Operators (and only Community Operators) then the observability-operator package we be available. Then finally if you don't have either of those for some reason, then prometheus-operator is the one it'd use.
Basically, any of these being installed will satisfy, but it will try to install in the order (bottom to top) as the preference.
So basically, in a new installation, cluster-observability-operator would be preferred over observability-operator. If prometheus-operator were installed, then that would satisfy for the dependencies, and would then pass the dependency checks.
Basically, if you already have observability-operator installed, the dependency check will pass, and OLM will move onto the next set of package manifest checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! I didn't realize the old naming would remain valid in the community operators catalog; thanks.
Add cluster observability operator as the preferred dependency (bottom
of list is highest priority) when installing Service Telemetry Operator.
The cluster-observability-operator is the name of the downstream
(product) bundle in the Red Hat Operators CatalogSource.
If installing for upstream, preferred operator will be
observability-operator (when the Red Hat Operators CatalogSource is not
available or enabled). And then as a fall-back method when neither
Observability Operator or Cluster Observability Operator is not
available, allow for Prometheus Operator from the Community Operators to
satisfy for the Prometheus storage backend.