Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Observability Operator dependency #504

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

leifmadsen
Copy link
Member

Add cluster observability operator as the preferred dependency (bottom
of list is highest priority) when installing Service Telemetry Operator.
The cluster-observability-operator is the name of the downstream
(product) bundle in the Red Hat Operators CatalogSource.

If installing for upstream, preferred operator will be
observability-operator (when the Red Hat Operators CatalogSource is not
available or enabled). And then as a fall-back method when neither
Observability Operator or Cluster Observability Operator is not
available, allow for Prometheus Operator from the Community Operators to
satisfy for the Prometheus storage backend.

Add cluster observability operator as the preferred dependency (bottom
of list is highest priority) when installing Service Telemetry Operator.
The cluster-observability-operator is the name of the downstream
(product) bundle in the Red Hat Operators CatalogSource.

If installing for upstream, preferred operator will be
observability-operator (when the Red Hat Operators CatalogSource is not
available or enabled). And then as a fall-back method when neither
Observability Operator or Cluster Observability Operator is not
available, allow for Prometheus Operator from the Community Operators to
satisfy for the Prometheus storage backend.
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7f6f84507588435c8eaf691f282906f6

✔️ stf-crc-latest-nightly_bundles SUCCESS in 17m 47s
stf-crc-latest-local_build FAILURE in 49m 07s

@leifmadsen
Copy link
Member Author

recheck

@@ -39,3 +39,6 @@ properties:
- package:
packageName: observability-operator
versionRange: '>=0.0.1'
- package:
packageName: cluster-observability-operator
Copy link
Collaborator

@csibbitt csibbitt Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same thing, right? observability-operator is renaming to cluster-observability-operator? Do we have any idea what happens if you've already installed it under the old name? I suppose we never released a version with the old name in place, so downstream customers at least would never be in this situation. Does that mean we can can/should remove the observability-operator version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically the downstream (Red Hat Operators CatalogSource) will ship observability-operator as cluster-observability-operator. If you didn't have Red Hat Operators (and only Community Operators) then the observability-operator package we be available. Then finally if you don't have either of those for some reason, then prometheus-operator is the one it'd use.

Basically, any of these being installed will satisfy, but it will try to install in the order (bottom to top) as the preference.

So basically, in a new installation, cluster-observability-operator would be preferred over observability-operator. If prometheus-operator were installed, then that would satisfy for the dependencies, and would then pass the dependency checks.

Basically, if you already have observability-operator installed, the dependency check will pass, and OLM will move onto the next set of package manifest checks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I didn't realize the old naming would remain valid in the community operators catalog; thanks.

@leifmadsen leifmadsen enabled auto-merge (squash) October 19, 2023 19:23
@leifmadsen leifmadsen merged commit 7eb2862 into master Oct 20, 2023
12 checks passed
@leifmadsen leifmadsen deleted the fixup/cobo-satisfies-deps branch October 20, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants