Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Observability Operator dependency #504

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Cluster Observability Operator dependency #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deploy/olm-catalog/service-telemetry-operator/metadata/properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,6 @@ properties:
- package:
packageName: observability-operator
versionRange: '>=0.0.1'
- package:
packageName: cluster-observability-operator
Copy link
Collaborator

@csibbitt csibbitt Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same thing, right? observability-operator is renaming to cluster-observability-operator? Do we have any idea what happens if you've already installed it under the old name? I suppose we never released a version with the old name in place, so downstream customers at least would never be in this situation. Does that mean we can can/should remove the observability-operator version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically the downstream (Red Hat Operators CatalogSource) will ship observability-operator as cluster-observability-operator. If you didn't have Red Hat Operators (and only Community Operators) then the observability-operator package we be available. Then finally if you don't have either of those for some reason, then prometheus-operator is the one it'd use.

Basically, any of these being installed will satisfy, but it will try to install in the order (bottom to top) as the preference.

So basically, in a new installation, cluster-observability-operator would be preferred over observability-operator. If prometheus-operator were installed, then that would satisfy for the dependencies, and would then pass the dependency checks.

Basically, if you already have observability-operator installed, the dependency check will pass, and OLM will move onto the next set of package manifest checks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I didn't realize the old naming would remain valid in the community operators catalog; thanks.

versionRange: '>=0.0.1'