Skip to content

chore: expand pnpm check to mirror full CI merge gate#2065

Closed
nick-inkeep wants to merge 2 commits intomainfrom
feat/local-ci-parity
Closed

chore: expand pnpm check to mirror full CI merge gate#2065
nick-inkeep wants to merge 2 commits intomainfrom
feat/local-ci-parity

Conversation

@nick-inkeep
Copy link
Collaborator

Summary

  • Expand pnpm check to chain turbo check + format:check + check:env-descriptions + knip — matching exactly what CI runs
  • Fix contributing docs: remove stale caveat about CI running extra checks, correct pre-push hook description
  • Update AGENTS.md to reflect that pnpm check now mirrors the full CI merge gate

Motivation

pnpm check was incomplete — it only ran the turbo subset (lint + typecheck + test), while CI also ran format:check, check:env-descriptions, and knip as separate steps. The CI failure summary misleadingly told developers "Run pnpm check locally to reproduce the CI checks." The extra steps add <8s to a ~2min run (measured locally), so there's no reason for them to be separate.

Part of the Local CI Parity spec. Playwright browser install deferred to after PR #2054 merges (introduces setup-dev.js).

Changes

  1. package.json — expand check script to chain all CI steps
  2. AGENTS.md — add pnpm check to Essential Commands, simplify verification commands section
  3. agents-docs/.../contributing/overview.mdx — remove CI extra-checks caveat, fix pre-push hook description (was wrong: claimed check:prepush but actually runs pnpm format)

What's NOT affected

  • check:husky and check:prepush — these reference turbo tasks directly in turbo.json, not the root check script
  • CI workflow — still runs steps separately for granular failure attribution
  • Pre-push / pre-commit hooks — unchanged

Test plan

  • pnpm check script correctly chains: turbo check && format:check && check:env-descriptions && knip
  • check:husky and check:prepush scripts unchanged (verified via node -e)
  • All three extra steps pass independently (format:check, check:env-descriptions, knip)
  • Pre-push hook file (.husky/pre-push) confirmed to run pnpm format (matches updated docs)
  • Lint-staged passes on commit

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Feb 17, 2026 4:46pm
agents-docs Ready Ready Preview, Comment Feb 17, 2026 4:46pm
agents-manage-ui Ready Ready Preview, Comment Feb 17, 2026 4:46pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

⚠️ No Changeset found

Latest commit: e8c708a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pnpm check previously only ran the turbo subset (lint + typecheck + test).
CI also ran format:check, check:env-descriptions, and knip as separate
steps. Now pnpm check chains all four, so "green locally = green in CI."

Also fixes contributing docs: pre-push hook description was wrong
(claimed check:prepush, actually runs pnpm format) and removes the
stale caveat about CI running extra checks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(1) Total Issues | Risk: Low

🟡 Minor (1) 🟡

Inline Comments:

  • 🟡 Minor: AGENTS.md:269 Inconsistent terminology — "format" vs "format:check"

💡 APPROVE WITH SUGGESTIONS

Summary: This is a clean, well-scoped PR that achieves its stated goal of local-CI parity. The documentation fixes are accurate (verified the pre-push hook does run pnpm format), and the script expansion correctly chains all CI steps. The only minor issue is a terminology inconsistency within AGENTS.md — one location says "format" while another says "format:check". A quick fix to use "format:check" consistently would improve clarity. Nice work! 🎉

Discarded (2)
Location Issue Reason Discarded
.github/workflows/ci.yml CI runs steps separately while local script chains them Intentional design per PR description — CI gets granular failure attribution, local gets fail-fast. Not an issue.
.github/workflows/ci.yml:21-34 Third-party GitHub Actions use mutable tags instead of SHA pins Pre-existing issue not introduced by this PR. Out of scope.
Reviewers (3)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
pr-review-docs 0 0 0 0 0 0 0
pr-review-devops 2 0 0 0 0 0 2
pr-review-consistency 1 0 0 0 1 0 0
Total 3 0 0 0 1 0 2

Addresses review feedback — line 269 said "format" but the actual
script runs format:check (verification, not auto-fix). Now matches
line 13 which correctly uses "format:check".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Delta Re-Review

This is a re-review scoped to changes since the previous automated review.

Delta: 1 commit (e8c708a9) · 1 file (AGENTS.md) · 1 line changed

Previous feedback status:

  • 🟡 Inconsistent "format" vs "format:check" terminology → ✅ Resolved — Line 269 now uses format:check, matching line 13

No new issues identified in the delta. The fix is correct and minimal.


✅ APPROVE

Summary: The previous review's feedback has been addressed with a clean 1-line fix. Both references to the check script now consistently use format:check terminology. Ship it! 🚀

Reviewers (0)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
N/A — trivial delta, no sub-reviewers dispatched

Note: Delta consisted of a single editorial fix addressing prior feedback. Sub-reviewer dispatch was skipped per orchestrator judgment.

@nick-inkeep
Copy link
Collaborator Author

CI Status Note: The failing ci check (pull_request trigger) is a pre-existing issue on maincors.test.ts failures introduced by PR #2066. The same test fails on the latest main branch CI run. Not related to this PR's changes.

All other checks pass:

  • ci (push trigger): pass
  • auto-format: pass
  • pr-review: pass (APPROVE)
  • Create Agents E2E Tests: pass
  • All 3 Vercel deploys: pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments