gate cors for local dev

[robert-inkeep]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Ready	Preview, Comment	Feb 17, 2026 3:38pm
agents-docs	Ready	Preview, Comment	Feb 17, 2026 3:38pm
agents-manage-ui	Ready	Preview, Comment	Feb 17, 2026 3:38pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 7e2677d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@inkeep/agents-api	Patch
@inkeep/agents-manage-ui	Patch
@inkeep/agents-cli	Patch
@inkeep/agents-core	Patch
@inkeep/agents-manage-mcp	Patch
@inkeep/agents-mcp	Patch
@inkeep/agents-sdk	Patch
@inkeep/agents-work-apps	Patch
@inkeep/ai-sdk-provider	Patch
@inkeep/create-agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[inkeep]

No documentation updates needed for this PR. This is an internal CORS security improvement that gates localhost origins to development/test environments only—no user-facing API or configuration changes.

[claude]

PR Review Summary

(2) Total Issues | Risk: Medium

🔴❗ Critical (1) ❗🔴

🔴 1) agents-api/src/__tests__/utils/cors.test.ts Missing ENVIRONMENT mock breaks existing tests and lacks production rejection coverage

files:

• agents-api/src/__tests__/utils/cors.test.ts
• agents-api/src/__tests__/manage/utils/cors.test.ts (duplicate test file)

Issue: The PR adds a new condition env.ENVIRONMENT === 'development' || env.ENVIRONMENT === 'test' to the localhost CORS check, but the existing CORS tests mock the env module without including ENVIRONMENT. Since the tests use vi.doMock('../../env', () => ({ env: {...} })) to completely replace the env export, env.ENVIRONMENT will be undefined during test execution — causing the new localhost condition to evaluate to false. This likely breaks existing tests that expect localhost origins to be allowed. Additionally, there are no tests that verify localhost is rejected in production or pentest environments, which is the core purpose of this security change.

Why: This is a security-related change intended to prevent localhost origins from being accepted in production environments. Without:

1. Fixing the existing mocks to include ENVIRONMENT: 'development' or ENVIRONMENT: 'test'
2. Adding explicit tests for ENVIRONMENT: 'production' and ENVIRONMENT: 'pentest' that verify localhost rejection

...a future developer could refactor the condition (e.g., invert the logic, remove the environment check) and the tests would either fail for the wrong reason or pass without verifying the security behavior.

Fix:

1. Update existing test mocks to include ENVIRONMENT:

// In "development mode (localhost API)" describe block (line 81-86)
vi.doMock('../../env', () => ({
  env: {
    INKEEP_AGENTS_API_URL: 'http://localhost:3002',
    INKEEP_AGENTS_MANAGE_UI_URL: undefined,
    ENVIRONMENT: 'development',  // Add this
  },
}));

2. Add new test cases for production/pentest rejection:

describe('production mode rejects localhost origins', () => {
  beforeEach(() => {
    vi.doMock('../../env', () => ({
      env: {
        ENVIRONMENT: 'production',
        INKEEP_AGENTS_API_URL: 'https://api.agents.inkeep.com',
        INKEEP_AGENTS_MANAGE_UI_URL: 'https://app.inkeep.com',
      },
    }));
  });

  it('should REJECT localhost origins in production', async () => {
    const { isOriginAllowed } = await import('../../middleware/cors');
    expect(isOriginAllowed('http://localhost:3000')).toBe(false);
    expect(isOriginAllowed('http://127.0.0.1:3000')).toBe(false);
  });

  it('should still allow configured UI URL in production', async () => {
    const { isOriginAllowed } = await import('../../middleware/cors');
    expect(isOriginAllowed('https://app.inkeep.com')).toBe(true);
  });
});

describe('pentest mode rejects localhost origins', () => {
  beforeEach(() => {
    vi.doMock('../../env', () => ({
      env: {
        ENVIRONMENT: 'pentest',
        INKEEP_AGENTS_API_URL: 'https://api.agents.inkeep.com',
        INKEEP_AGENTS_MANAGE_UI_URL: 'https://app.inkeep.com',
      },
    }));
  });

  it('should REJECT localhost origins in pentest', async () => {
    const { isOriginAllowed } = await import('../../middleware/cors');
    expect(isOriginAllowed('http://localhost:3000')).toBe(false);
    expect(isOriginAllowed('http://127.0.0.1:3000')).toBe(false);
  });
});

Refs:

• cors.test.ts:81-86 — mock missing ENVIRONMENT
• cors.ts:42-47 — new environment check
• vitest.config.ts:28 — ENVIRONMENT set to 'test' globally
• workAppsAuth.ts:33-49 — existing pattern for environment-gated localhost

🟡 Minor (1) 🟡

Inline Comments:

• 🟡 Minor: .changeset/smart-clocks-cover.md:5 Changeset message truncated mid-sentence

---

🚫 REQUEST CHANGES

Summary: The CORS security hardening is a good change that aligns with existing patterns (e.g., workAppsAuth.ts). However, the existing test suite needs to be updated to: (1) include ENVIRONMENT in the mocked env objects so tests don't break, and (2) add explicit test coverage for localhost rejection in production/pentest environments to validate the security behavior being introduced.

Discarded (1)

Location	Issue	Reason Discarded
agents-api/src/middleware/cors.ts	Security assessment of the change itself	Validated as correct — the change improves security by gating localhost to dev/test only. No security concerns found.

Reviewers (4)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
pr-review-standards	1	1	0	0	0	0	0
pr-review-tests	2	1	0	0	0	0	0
pr-review-devops	3	0	0	0	1	0	1
pr-review-security-iam	1	0	0	0	0	0	1
Total	7	1	0	0	1	0	2

Note: Findings from pr-review-standards, pr-review-tests, and pr-review-devops about test coverage were semantically deduplicated into a single Critical finding since they all addressed the same underlying issue.

[claude]

🟡 Minor: Changeset message truncated

Issue: The changeset description ends mid-sentence: "...or the origin to share the same base" — missing the completion.

Why: Incomplete changelog messages can confuse package consumers trying to understand the release behavior.

Fix: (1-click apply)

Suggested change

	Now localhost origins are only allowed when ENVIRONMENT is development or test. In production/pentest, CORS will require either INKEEP_AGENTS_MANAGE_UI_URL to be set or the origin to share the same base
	Now localhost origins are only allowed when ENVIRONMENT is development or test. In production/pentest, CORS will require either INKEEP_AGENTS_MANAGE_UI_URL to be set or the origin to share the same base domain as the API.

Refs:

• Changeset docs