Optimize CustomMarkerClass draw Method #281
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on the issue: #90 and #162
Changes:
Forced redraw is a result of the following causing significant lag while zooming:
Instead of getting the width and height of a given element, we can use CSS transforms to position marker based on its already calculated width. When using
position: absolute; top: x, left: x
- we can also assume that the item is being positioned in the bottom right corner of a given marker (thus making repositioning easier).If we want to continue to use the offsetX and offsetY optional configuration, just add it to point.x and point.y instead.
Result:
I've only been able to test locally, but I more or less have completely removed the lag associated with zooming on 500+ CustomMarkers. Looking for someone to help me validate.