Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CustomMarkerClass draw Method #281

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Optimize CustomMarkerClass draw Method #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
723a760
Replacing offsetHeight / Width with transformX, Y alternative
Sep 10, 2024
9ede0a3
The zillow way, using only transforms for positioning.
radiantstatic Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,52 +63,51 @@ export function createCustomMarkerClass(api: typeof google.maps): ICustomMarkerC

if (point) {
this.element.style.position = "absolute";
const height = this.element.offsetHeight;
const width = this.element.offsetWidth;
let x: number, y: number;
let transformX: string, transformY: string;

switch (this.opts.anchorPoint) {
case "TOP_CENTER":
x = point.x - width / 2;
y = point.y;
transformX = "-50%";
transformY = "-100%";
break;
case "BOTTOM_CENTER":
x = point.x - width / 2;
y = point.y - height;
transformX = "-50%";
transformY = "0";
break;
case "LEFT_CENTER":
x = point.x;
y = point.y - height / 2;
transformX = "-100%";
transformY = "-50%";
break;
case "RIGHT_CENTER":
x = point.x - width;
y = point.y - height / 2;
transformX = "0";
transformY = "-50%";
break;
case "TOP_LEFT":
x = point.x;
y = point.y;
transformX = "-100%";
transformY = "-100%";
break;
case "TOP_RIGHT":
x = point.x - width;
y = point.y;
transformX = "0";
transformY = "-100%";
break;
case "BOTTOM_LEFT":
x = point.x;
y = point.y - height;
transformX = "-100%";
transformY = "0";
break;
case "BOTTOM_RIGHT":
x = point.x - width;
y = point.y - height;
transformX = "0";
transformY = "0";
break;
default:
// "center"
x = point.x - width / 2;
y = point.y - height / 2;
transformX = "-50%";
transformY = "-50%";
}

this.element.style.left = x + "px";
this.element.style.top = y + "px";
const xPos = point.x + (this.opts.offsetX || 0) + "px";
const yPos = point.y + (this.opts.offsetY || 0) + "px";
// eslint-disable-next-line prettier/prettier
this.element.style.transform = `translateX(${this.opts.offsetX || 0}px) translateY(${this.opts.offsetY || 0}px)`;
this.element.style.transform = `translateX(${transformX}) translateX(${xPos}) translateY(${transformY}) translateY(${yPos})`;

if (this.opts.zIndex) {
this.element.style.zIndex = this.opts.zIndex.toString();
Expand Down