ETCM-12351 dolos auth selection data source #1064
Closed
+460
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpinter-iohk
force-pushed
the
ETCM-12351-dolos-auth-selection-data-source
branch
2 times, most recently
from
5086ea3 to
119950d
Compare
kpinter-iohk
force-pushed
the
ETCM-12351-dolos-auth-selection-data-source
branch
from
119950d to
175175c
Compare
kpinter-iohk
force-pushed
the
ETCM-12351-dolos-auth-selection-data-source
branch
from
ccf95d0 to
17835d2
Compare
|
Merged with #1075 |
LGLO
reviewed
Nov 5, 2025
|
|
||
| fn format_asset_id(asset_id: &AssetId) -> String { | ||
| let AssetId { policy_id, asset_name } = asset_id; | ||
| format!("{}{}", &policy_id.to_hex_string()[2..], &asset_name.to_hex_string()[2..]) |
There was a problem hiding this comment.
Is it really concat without a separator?
There was a problem hiding this comment.
Yes, this has been tested against a running Dolos instance too. (docs)
LGLO
reviewed
Nov 5, 2025
| _reference_timestamp: sp_timestamp::Timestamp, | ||
| ) -> Result<Option<MainchainBlock>> { | ||
| Err("not implemented".into()) | ||
| Ok(Some(from_block_content(self.client.blocks_latest().await?)?)) |
There was a problem hiding this comment.
This will fail when syncing to existing network, wouldn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following using Dolos:
It also fixes some bugs in the miniBF client.
Checklist
changelog.mdfor affected crate