-
Notifications
You must be signed in to change notification settings - Fork 23
chore: add nix builds and caching #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Approved, though I don't entirely understand why we need to merge a second CI workflow into master. If your tests of Attic are working then can go straight to modifying the main ci.yml workflow and testing in a branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested nix dev shell with my workflows, looking good! 🧑🍳👌
We can use it on the single CI job. I'll need to test it first on this branch with the rest of the workflow. thanks |
Description
We're currently using the nix devshells locally and in the CI, but with a raw cargo caching solution on our infra. This PR builds our substrate project using https://github.com/ipetkov/crane, a minimal nix-based wrapper that also excels at only rebuilding direct dependencies and not rebuilding upstream deps like the substrate project unless Cargo.lock changes for it. In the process it simplifies the caching solution and LOC required by using nix for caching, a task at which it already excels at.
This PR keeps the current devshell workflow and does not modify it. This PR does not modify the normal CI workflow as of yet-- instead for now it adds a new github action workflow for testing purposes.
Tested on macOS and Linux for building with cargo directly.
https://input-output.atlassian.net/browse/ETCM-12378?atlOrigin=eyJpIjoiNGZhOGYzMzdkZjEwNGU5NmI3MzMxODZjMDYzOGRmZmQiLCJwIjoiaiJ9
Checklist
changelog.mdfor affected crate