add native stake to d-param #1072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankun4
force-pushed
the
native-stake-d-param
branch
6 times, most recently
from
9447854 to
775efeb
Compare
AmbientTea
requested changes
Oct 30, 2025
| pub num_permissioned_candidates: u16, | ||
| /// The number of registered candidates | ||
| pub num_registered_candidates: u16, | ||
| /// The number of native stake validators |
There was a problem hiding this comment.
Suggested change
| /// The number of native stake validators | |
| /// The number of native stake candidates |
toolkit/sidechain/domain/src/lib.rs
Outdated
| )] | ||
| #[cfg_attr(feature = "serde", derive(Serialize))] | ||
| /// Parameter controlling the number and proportion of registered and permissioned candidates | ||
| /// Parameter controlling the number and proportion of registered, permissioned candidates and native stake validators |
There was a problem hiding this comment.
Suggested change
| /// Parameter controlling the number and proportion of registered, permissioned candidates and native stake validators | |
| /// Parameter controlling the number and proportion of registered, permissioned, and native stake candidates |
toolkit/sidechain/domain/src/lib.rs
Outdated
| pub num_permissioned_candidates: u16, | ||
| /// Expected number of registered candidates selected for a committee | ||
| pub num_registered_candidates: u16, | ||
| /// Expected number of native stake validators selected for a committee |
There was a problem hiding this comment.
Suggested change
| /// Expected number of native stake validators selected for a committee | |
| /// Expected number of native stake candidates selected for a committee |
| /// Number of registered candidates | ||
| registered_candidates_count: u16, | ||
| #[arg(long)] | ||
| /// Number of native stake validators |
There was a problem hiding this comment.
Suggested change
| /// Number of native stake validators | |
| /// Number of native stake candidates |
Comment on lines
54
to
+69
| impl From<DParamDatum> for sidechain_domain::DParameter { | ||
| fn from(datum: DParamDatum) -> Self { | ||
| match datum { | ||
| DParamDatum::V0 { num_permissioned_candidates, num_registered_candidates } => { | ||
| Self { num_permissioned_candidates, num_registered_candidates } | ||
| DParamDatum::V0 { num_permissioned_candidates, num_registered_candidates } => Self { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates: 0, | ||
| }, | ||
| DParamDatum::V1 { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates, | ||
| } => Self { | ||
| num_permissioned_candidates, | ||
| num_registered_candidates, | ||
| num_native_stake_candidates, |
There was a problem hiding this comment.
Have you tested upgrading a chain to this version? I'm pretty sure this will break existing chains that use the current 2-value d-param. We need to introduce DParameterV2, bump the selection pallet's version, and modify the Ariadne IDP to be version-aware so it knows what schema of inputs it should provide to the pallet.
jankun4
force-pushed
the
native-stake-d-param
branch
from
775efeb to
ba9b7aa
Compare
jankun4
force-pushed
the
native-stake-d-param
branch
from
ba9b7aa to
ad992c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds third value to D-Param feature. Now it supports native stake (mNIGHT) validators to take part in the consensus.
link
Checklist
changelog.mdfor affected crate