Skip to content

Conversation

@AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Oct 30, 2025

Description

Removes dependency on slots and abstracts them into a Moment type

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@AmbientTea AmbientTea changed the base branch from master to remove-slot-dependency-from-block-production-log October 30, 2025 12:47
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-production-log branch 2 times, most recently from dda9e3f to aebb32a Compare October 31, 2025 13:12
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-participation branch from cc9176e to 2e186a5 Compare October 31, 2025 14:00
@AmbientTea AmbientTea marked this pull request as ready for review October 31, 2025 15:41
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-participation branch 2 times, most recently from 216e794 to 0923641 Compare November 2, 2025 10:54
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-production-log branch 2 times, most recently from ba70542 to dd162d7 Compare November 4, 2025 09:26
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-participation branch from 8f5580c to 2707597 Compare November 4, 2025 09:27
Base automatically changed from remove-slot-dependency-from-block-production-log to master November 4, 2025 10:44
@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-participation branch from 2707597 to 40bc1ec Compare November 4, 2025 10:44
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic Moment is better than a Slot, but using other Slot again as concrete type of Moment is a somehow lost opportunity here. The problem is that we still try to anchor some notion of timestamp.

The problem manifests in the most visible way when blockchain stopped to operate for some time and it is coming back. Then the wall-clock time of the block creation does not matter. We need at least on block per each past PC epoch to be created. It is created by a member of committee selected using SPDD from some past MC epoch (I mean, older than two epoch boundaries).

Not a deal breaker for me (we were happy with slots), but something to consider.

@AmbientTea
Copy link
Contributor Author

Generic Moment is better than a Slot, but using other Slot again as concrete type of Moment is a somehow lost opportunity here. The problem is that we still try to anchor some notion of timestamp.

The problem manifests in the most visible way when blockchain stopped to operate for some time and it is coming back. Then the wall-clock time of the block creation does not matter. We need at least on block per each past PC epoch to be created. It is created by a member of committee selected using SPDD from some past MC epoch (I mean, older than two epoch boundaries).

Not a deal breaker for me (we were happy with slots), but something to consider.

Good catch, this is important, but we will address it as a separate issue.

@AmbientTea AmbientTea force-pushed the remove-slot-dependency-from-block-participation branch from 40bc1ec to fe70255 Compare November 5, 2025 15:08
@AmbientTea AmbientTea changed the title change: Remove slot dependency from block participation change: ETCM-12423 decouple block participation from slots Nov 5, 2025
@AmbientTea AmbientTea enabled auto-merge (squash) November 5, 2025 15:12
@AmbientTea AmbientTea merged commit ed496c6 into master Nov 5, 2025
25 checks passed
@AmbientTea AmbientTea deleted the remove-slot-dependency-from-block-participation branch November 5, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants