Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.2 URL validator: "localhost" with port number is invalid #28

Closed
ghost opened this issue Feb 21, 2019 · 1 comment
Closed

v1.3.2 URL validator: "localhost" with port number is invalid #28

ghost opened this issue Feb 21, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Feb 21, 2019

While 1.3.2 now flags "http://localhost" as a valid URL, "http://localhost:80", "http://localhost:8000", "https://localhost:8000/somepath" etc. are still flagged as invalid.

@insightindustry insightindustry self-assigned this Feb 23, 2019
@insightindustry insightindustry added the bug Something isn't working label Feb 23, 2019
@insightindustry insightindustry added this to the 1.3.3 milestone Feb 23, 2019
@insightindustry
Copy link
Owner

Thanks! Great catch. I’ll fix it in the next release (possibly over this weekend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant