Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special URL and Special IP Port/Path/Authentication Bug #30

Merged
merged 4 commits into from
Mar 23, 2019

Conversation

insightindustry
Copy link
Owner

Closes #28 and #29 : Fixed errors related to validation of URLs with special URLs (localhost) and special IPs (10.1.1.1) when used with port numbers, paths, or authentication.

@insightindustry insightindustry added this to the 1.3.3 milestone Mar 23, 2019
@insightindustry insightindustry self-assigned this Mar 23, 2019
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #30 into develop will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    83.62%   83.82%   +0.19%     
===========================================
  Files            4        4              
  Lines         1295     1298       +3     
  Branches       308      309       +1     
===========================================
+ Hits          1083     1088       +5     
+ Misses         130      129       -1     
+ Partials        82       81       -1
Impacted Files Coverage Δ
validator_collection/validators.py 85.9% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6496538...4746732. Read the comment docs.

@insightindustry insightindustry merged commit 7fc7962 into develop Mar 23, 2019
@insightindustry insightindustry deleted the special-url-port-bug branch March 23, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant