Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL checker does not support private IPs #29

Closed
fschoenm opened this issue Mar 19, 2019 · 2 comments
Closed

URL checker does not support private IPs #29

fschoenm opened this issue Mar 19, 2019 · 2 comments
Assignees
@insightindustry
Labels
duplicate This issue or pull request already exists
Milestone
1.3.3

Comments

@fschoenm
Copy link

The following URL check fails even though it should be correct:

is_url('http://127.0.0.1:8443/index.html', allow_special_ips=True)

When using a public IP (e.g. 1.1.1.1), it seems to work.
@insightindustry insightindustry self-assigned this Mar 19, 2019
@insightindustry insightindustry added the duplicate This issue or pull request already exists label Mar 19, 2019
@insightindustry insightindustry added this to the 1.3.3 milestone Mar 19, 2019
@insightindustry
Copy link
Owner

This is caused by the same root problem as #28 . Will be fixed in v. 1.3.3.

insightindustry added a commit that referenced this issue Mar 23, 2019
@insightindustry
Closes #28 and #29: Fixed false-negatives on special URLs and special…
c5d907d 
… IPs with port numbers, authentication, and/or path combinations.
@insightindustry insightindustry mentioned this issue Mar 23, 2019
Merged
@insightindustry
Copy link
Owner

Closed in v.1.3.3 by #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insightindustry insightindustry

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
2 participants
@fschoenm @insightindustry