Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that object is instance of Iterable in is_iterable #46

Merged

Conversation

aivrit
Copy link

@aivrit aivrit commented Nov 25, 2019

Added an assertion to is_iterable that verifies the object is an instance of Iterable in addition to the built in python check.
If the assertion will fail the function will return False as expected.
This will fix issue #45
Thanks!

@insightindustry insightindustry self-assigned this Nov 26, 2019
@insightindustry insightindustry added the bug Something isn't working label Nov 26, 2019
@insightindustry insightindustry changed the base branch from develop to patch_is_iterable December 7, 2019 18:35
@insightindustry
Copy link
Owner

Thanks! This is a helpful suggestion, and I'd like to take a closer look at the PR. I'm merging the PR into a new branch for patch_is_iterable where I'd like to implement a variety of unit tests to ensure that a) we have good test coverage for this edge case, and b) it is functional across all the versions of Python supported by the Validator Collection.

@insightindustry insightindustry merged commit ba51802 into insightindustry:patch_is_iterable Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants