Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with is_iterable checker #45

Closed
aivrit opened this issue Nov 25, 2019 · 0 comments · Fixed by #48
Closed

Issue with is_iterable checker #45

aivrit opened this issue Nov 25, 2019 · 0 comments · Fixed by #48
Assignees
@insightindustry
Labels
bug Something isn't working
Milestone
v.1.3.8

Comments

@aivrit
Copy link

aivrit commented Nov 25, 2019

Hi,using checkers.is_iterable returns True in cases where the object is not actually iterable.
the built-in checker only checks for an iter function, which exists for some classes (like the BaseQuery class of flask_sqlalchemy) even though it's not actually Iterable.
My suggestion is to add to the checkers.is_iterable function an assertion that also checks that the object is an instance of "Iterable" .
Thanks!
This was referenced Nov 25, 2019
Merged
Closed
@insightindustry insightindustry self-assigned this Nov 26, 2019
@insightindustry insightindustry added the bug Something isn't working label Nov 26, 2019
@insightindustry insightindustry added this to the v.1.3.8 milestone Nov 26, 2019
insightindustry added a commit that referenced this issue Dec 7, 2019
@insightindustry
#45: Implemented more robust iteration protocol checking for iterable…
25767dd 
… validation.
insightindustry added a commit that referenced this issue Dec 7, 2019
@insightindustry
#45: Removed a Python version-dependent import statement.
021bc9d
insightindustry added a commit that referenced this issue Dec 7, 2019
@insightindustry
#45: Fixed unit tests for tests to pass/fail correctly when testing i…
ea241c8 
…n Python 2.7.
@insightindustry insightindustry mentioned this issue Dec 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insightindustry insightindustry

Labels
bug Something isn't working
Projects
None yet
Milestone
v.1.3.8
Development

Successfully merging a pull request may close this issue.

Merging v.1.3.8 into master in preparation for release. insightindustry/validator-collection
2 participants
@aivrit @insightindustry