Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging v.1.3.8 into master in preparation for release. #48

Merged
merged 10 commits into from
Dec 7, 2019
Merged

Merging v.1.3.8 into master in preparation for release. #48

merged 10 commits into from
Dec 7, 2019

Conversation

insightindustry
Copy link
Owner

Alon Bar Tzlil and others added 10 commits November 25, 2019 11:54
add assertion check that object is instance of Iterable, to checker i…
39c9892 
…s_iterable
add assertion check that object is instance of Iterable, to checker i…
e521889 
…s_iterable
@insightindustry
Merge pull request #46 from aivrit/patch_is_iterable
ba51802 
Merging into a new branch to add unit tests and ensure Python version support.
@insightindustry
#45: Implemented more robust iteration protocol checking for iterable…
25767dd 
… validation.
@insightindustry
#45: Removed a Python version-dependent import statement.
021bc9d
@insightindustry
#45: Fixed unit tests for tests to pass/fail correctly when testing i…
ea241c8 
…n Python 2.7.
@insightindustry
Merge pull request #47 from insightindustry/patch_is_iterable
375a8b3 
Robust support for different iteration protocols
@insightindustry
#43: Adjusted how __init__.py collects version information.
36e0693
@insightindustry
#43: Adjusted version file encoding to maintain unit tests.
67c5a00
@insightindustry
Updated README, contributor list, version number, etc.
d474b27
@insightindustry insightindustry added this to the v.1.3.8 milestone Dec 7, 2019
@insightindustry insightindustry self-assigned this Dec 7, 2019
@codecov
Copy link

codecov bot commented Dec 7, 2019 •
edited
Loading

Codecov Report

Merging #48 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   83.38%   83.48%   +0.09%     
==========================================
  Files           4        4              
  Lines        1324     1332       +8     
  Branches      316      317       +1     
==========================================
+ Hits         1104     1112       +8     
  Misses        137      137              
  Partials       83       83
Impacted Files Coverage Δ
validator_collection/validators.py 85.68% <100%> (+0.1%) ⬆️
validator_collection/errors.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ce607...d474b27. Read the comment docs.

@insightindustry insightindustry merged commit b7e3e58 into master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@insightindustry insightindustry

Labels
None yet
Projects
None yet
Milestone
v.1.3.8
Development

Successfully merging this pull request may close these issues.

Issue with is_iterable checker reading the _version.py file in __init__ gives pyinstaller lots of trouble
1 participant
@insightindustry