Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed credential file existence check with spn values check #40

Closed

Conversation

gianlucaciocci
Copy link

@gianlucaciocci gianlucaciocci commented Jun 7, 2017

This pull request covers the issue titled "env variables azure_backend.rb library issue, if credential file not present".

Signed-off-by: Gianluca Ciocci gianluca.ciocci@contino.io

Signed-off-by: Gianluca Ciocci <gianluca.ciocci@contino.io>
@gianlucaciocci gianlucaciocci force-pushed the azure-env-credential-fix branch from 996c17d to 154db7d Compare June 12, 2017 12:28
@gianlucaciocci
Copy link
Author

I am not understanding why TravisCi checks are failing...anyone can help? What am I missing? I haven't a Travis CI for private projects account...does that have an impact on those checks?

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gianlucaciocci This makes sense :-)

@chris-rock
Copy link
Contributor

@gianlucaciocci Thank you very much for the PR. You and @russellseymour did a great job covering the additional check. We opted for #42 since it was already green. Please let me know if you agree with that decision or if you think we missed something.

@gianlucaciocci
Copy link
Author

Hi @chris-rock, thanks a lot for this message and for taking @russellseymour merge. I was actually looking forward to this fix. So no problem at all.
On another note, what's your plan about inspec for Azure. We are "using it in anger" on a project I am on...

@chris-rock
Copy link
Contributor

@gianlucaciocci We are currently working on InSpec 2.0 https://github.com/chef/inspec/milestone/26 which includes to implement the RFC Platforms inspec/inspec#1661. Once this is in, we are going to merge this repo into core inspec. Not sure what you mean by "using it in anger"? Can you explain this more?

@chris-rock chris-rock closed this Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants