Updated so that the credentials file is only interogated if it exists

[russellseymour]

Fixes #39

Signed-off-by: Russell Seymour russell.seymour@turtlesystems.co.uk

[russellseymour]

Fixes issue when only using environment variables
It was mistakenly checking for the credentials file

/cc @adamleff @chris-rock

[adamleff]

Seems like a reasonable change to me!

My only suggestion: when a variable (like @credentials) contains contents, I tend to like to set the variable to nil instead of false if the file doesn't exist or can't be read. Then down around like 60, it would say unless @credentials.nil? rather than if @credentials. Perhaps it's personal preference, but I think it's clearer.

Alternatively, and mostly because I like to break things up into small methods to make testing easier, I would consider creating a method credentials_file_exists? and using that in lines 29 and line 60 instead.

But this is totally fine as-is as far as I'm concerned. :)

[chris-rock]

I would like to see the improvement mentioned by @adamleff implemented, since we assign false to a variable that holds the content of the ini file. Therefore we really should just check for nil.

[gianlucaciocci]

the pull request #40 and this one are a duplicate, both are trying to fix the same issue. Could you please advice the way to go? If we decide to go with this implementation I'll delete the fix included into the pull request mentioned. Please let me know, thanks.

[russellseymour]

I have modified the @credentials so that it is nil if there is no credentials file.

I have not added tge method credentials_file_exists? because the file is only checked for existence in the initialize method. The next check is to detetermine if the subscription is set in the contents of the credentials file which has be loaded and not the file path.

Sorry for the delay in sorting this, I need to get my GitHub alerts sorted.

/cc @adamleff @chris-rock @gianlucaciocci

[chris-rock]

Thank you @russellseymour

[Tushard8]

Guy's, I am facing related issue after recent changes in repo. I am a tester and using this repo to write tests for checking Azure VM's hosted in our Infra.

https://github.com/chef/inspec-azure/issues/58

What am I doing wrong here ?