Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: do not use a fixed urllib3 version #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setup: do not use a fixed urllib3 version #462

wants to merge 1 commit into from

Conversation

miguelgrc
Copy link
Contributor

@miguelgrc miguelgrc force-pushed the bump-urllib3 branch 3 times, most recently from 63bf018 to 0163751 Compare August 21, 2024 11:10
PascalEgn
PascalEgn reviewed Aug 21, 2024
View reviewed changes
setup.py
@@ -213,15 +213,12 @@ def do_setup():
'inspire-idutils==1.2.4; python_version == "2.7"',
'idutils~=1.2,>=1.2.1; python_version >= "3"',
'isbnid',
'inspire-utils~=3.0,>=3.0.0',
'inspire-utils',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add 'inspire-utils @ git+https://github.com/miguelgrc/inspire-utils.git@bump-urllib3#egg=inspire-utils',

Kinda curious what happens then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and the tests were also passing. The problem comes when also pulling inspire-schemas from git in inspire-utils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalEgn PascalEgn PascalEgn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgrc @PascalEgn