Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: do not use a fixed urllib3 version #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setup: do not use a fixed urllib3 version #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
- name: Install python dependencies
run: |
${{ matrix.pip }} install --user --upgrade pip
${{ matrix.pip }} --no-cache-dir install --user setuptools wheel "urllib3==1.25.11"
${{ matrix.pip }} --no-cache-dir install --user -e .[tests,docs]

- name: Show python dependencies
Expand Down Expand Up @@ -108,7 +107,6 @@ jobs:
- name: Install python dependencies
run: |
python -m pip install --upgrade pip
pip --no-cache-dir install setuptools wheel "urllib3==1.25.11"
pip --no-cache-dir install -e .[tests,docs]

- name: Show python dependencies
Expand Down
5 changes: 1 addition & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,12 @@ def do_setup():
'inspire-idutils==1.2.4; python_version == "2.7"',
'idutils~=1.2,>=1.2.1; python_version >= "3"',
'isbnid',
'inspire-utils~=3.0,>=3.0.0',
'inspire-utils',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add 'inspire-utils @ git+https://github.com/miguelgrc/inspire-utils.git@bump-urllib3#egg=inspire-utils',

Kinda curious what happens then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and the tests were also passing. The problem comes when also pulling inspire-schemas from git in inspire-utils

'isodate',
'pyyaml==5.3.0',
'pytz',
'rfc3987',
'six',
# requests requires a urllib3 version <1.26 but not 1.25.0 and 1.25.1
# we pin it down here to solve dependency problems
'urllib3>=1.21.1,<1.26,!=1.25.0,!=1.25.1',
],
tests_require=tests_require,
extras_require=extras_require,
Expand Down
Loading