-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamodb): added endpoint filtering #1484
Conversation
f27e6e5
to
bc61f37
Compare
const mappings = fieldMappings[spanName]; | ||
if (!mappings || !span.data[spanName]) return span; | ||
|
||
Object.keys(span.data[spanName]).forEach(internalField => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: It could be that a span contains multiple data keys. But I have never seen a case where two instrumentation keys were present. I think only with the SDK 🤔
But I would ignore that for now I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e8b57c4
to
2d81d8f
Compare
Enabled configuration to exclude specific
dynamodb
commands from tracing.This can be configured via following ways:
Add the configuration to the agent's
configuration.yaml
file:Tracer configuration:
Using an Environment Variable:
INSTANA_IGNORE_ENDPOINTS=dynamodb:query,listTables;
With this setup, the tracer will ignore dynamodb commands such as
QUERY
orLISTTABLES
, and any other dynamodb command can be added to the list for exclusion. This enhancement improves performance by reducing unnecessary tracing for specific dynamodb operations.TODO
ref INSTA-16323
ref #1448