Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): added endpoint filtering #1484

Merged
merged 8 commits into from
Dec 13, 2024
Merged

feat(dynamodb): added endpoint filtering #1484

merged 8 commits into from
Dec 13, 2024

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Dec 12, 2024

Enabled configuration to exclude specific dynamodb commands from tracing.

This can be configured via following ways:

Add the configuration to the agent's configuration.yaml file:

com.instana.tracing:
    ignore-endpoints: 
       dynamodb: 
         - query
         - listTables

Tracer configuration:

tracing: {
  ignoreEndpoints: {
    dynamodb: ['query']
  }
}

Using an Environment Variable:

INSTANA_IGNORE_ENDPOINTS=dynamodb:query,listTables;

With this setup, the tracer will ignore dynamodb commands such as QUERY or LISTTABLES, and any other dynamodb command can be added to the list for exclusion. This enhancement improves performance by reducing unnecessary tracing for specific dynamodb operations.

TODO

ref INSTA-16323
ref #1448

@aryamohanan aryamohanan force-pushed the fup-dynamodb branch 4 times, most recently from f27e6e5 to bc61f37 Compare December 12, 2024 08:39
@aryamohanan aryamohanan marked this pull request as ready for review December 12, 2024 09:30
@aryamohanan aryamohanan requested a review from a team as a code owner December 12, 2024 09:30
const mappings = fieldMappings[spanName];
if (!mappings || !span.data[spanName]) return span;

Object.keys(span.data[spanName]).forEach(internalField => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general: It could be that a span contains multiple data keys. But I have never seen a case where two instrumentation keys were present. I think only with the SDK 🤔
But I would ignore that for now I guess.

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryamohanan aryamohanan merged commit 93e4023 into main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants