Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): added endpoint filtering #1448

Merged
merged 23 commits into from
Dec 5, 2024
Merged

feat(redis): added endpoint filtering #1448

merged 23 commits into from
Dec 5, 2024

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Nov 13, 2024

Introduced a configuration to exclude specific Redis commands from tracing.

This can be configured via following ways:

Add the configuration to the agent's configuration.yaml file:

com.instana.tracing:
    ignore-endpoints: 
       redis: 
         - get
         - type

Tracer configuration:

tracing: {
  ignoreEndpoints: {
    redis: ['type', 'get']
  }
}

Using an Environment Variable:

INSTANA_IGNORE_ENDPOINTS=redis:get,type;

With this setup, the tracer will ignore Redis commands such as TYPE or GET, and any other Redis command can be added to the list for exclusion. This enhancement improves performance by reducing unnecessary tracing for specific Redis operations.

TODO

ref INSTA-16323
design discussion https://github.ibm.com/instana/requests-for-discussion/pull/84

@aryamohanan aryamohanan changed the title feat: added configuration to ignore specific endpoints from tracing. feat: added configuration to ignore specific endpoints from tracing Nov 14, 2024
@aryamohanan aryamohanan force-pushed the ignore-endpoint branch 3 times, most recently from d087cae to 64900b4 Compare November 18, 2024 08:23
@aryamohanan aryamohanan force-pushed the ignore-endpoint branch 2 times, most recently from c03864a to db431ac Compare November 28, 2024 08:26
@aryamohanan aryamohanan changed the title feat: added configuration to ignore specific endpoints from tracing feat: added configuration to ignore specific redis endpoints from tracing Nov 28, 2024
@aryamohanan aryamohanan changed the title feat: added configuration to ignore specific redis endpoints from tracing feat: added config option to exclude specific Redis endpoints from tracing Nov 28, 2024
@aryamohanan aryamohanan marked this pull request as ready for review November 28, 2024 08:43
@aryamohanan aryamohanan requested a review from a team as a code owner November 28, 2024 08:43
@kirrg001 kirrg001 removed the WIP label Nov 28, 2024
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

packages/core/src/util/spanFilter.js Outdated Show resolved Hide resolved
packages/collector/test/announceCycle/unannounced_test.js Outdated Show resolved Hide resolved
packages/collector/src/announceCycle/unannounced.js Outdated Show resolved Hide resolved
packages/collector/src/announceCycle/unannounced.js Outdated Show resolved Hide resolved
packages/collector/test/announceCycle/unannounced_test.js Outdated Show resolved Hide resolved
packages/core/src/util/spanFilter.js Outdated Show resolved Hide resolved
packages/core/src/util/spanFilter.js Outdated Show resolved Hide resolved
packages/core/src/tracing/spanBuffer.js Show resolved Hide resolved
packages/core/test/tracing/spanBuffer_test.js Outdated Show resolved Hide resolved
@aryamohanan aryamohanan force-pushed the ignore-endpoint branch 2 times, most recently from d26f269 to 536f492 Compare November 29, 2024 10:26
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments incoming 🚢

packages/core/src/util/normalizeConfig.js Outdated Show resolved Hide resolved
packages/core/src/util/normalizeConfig.js Outdated Show resolved Hide resolved
packages/core/src/util/normalizeConfig.js Outdated Show resolved Hide resolved
packages/collector/test/apps/agentStub.js Outdated Show resolved Hide resolved
packages/collector/test/apps/agentStubControls.js Outdated Show resolved Hide resolved
packages/core/src/tracing/backend_mappers/index.js Outdated Show resolved Hide resolved
packages/core/src/util/spanFilter.js Outdated Show resolved Hide resolved
@kirrg001
Copy link
Contributor

kirrg001 commented Dec 2, 2024

Commit suggestion:

feat: added config option to exclude specific Redis endpoints from tracing #1448

feat(redis): added endpoint filtering

@aryamohanan aryamohanan changed the title feat: added config option to exclude specific Redis endpoints from tracing feat(redis): added endpoint filtering Dec 3, 2024
@aryamohanan aryamohanan requested a review from kirrg001 December 3, 2024 10:49
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments 🧜🏽

@aryamohanan aryamohanan merged commit 2f45ff7 into main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants