Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8 profiler binaries can no longer be downloaded #19

Closed
bripkens opened this issue Nov 20, 2017 · 4 comments
Closed

v8 profiler binaries can no longer be downloaded #19

bripkens opened this issue Nov 20, 2017 · 4 comments

Comments

@bripkens
Copy link
Contributor

See node-inspector/v8-profiler#117
@bripkens bripkens added the bug label Nov 20, 2017
@bripkens bripkens removed the bug label Apr 3, 2018
@ingo-eichhorst
Copy link

ingo-eichhorst commented Sep 25, 2018 •
edited
Loading

The problem seems be recurring:

npm install instana-nodejs-sensor and
npm install v8-profiler fails

os: MacOS 10.13.6
instana-nodejs-sensor: 1.48.1

lead to (note: replaced absolute paths with ...):

> v8-profiler@5.7.0 preinstall .../node_modules/v8-profiler
> node -e 'process.exit(0)'

> @risingstack/v8-profiler@5.7.11 preinstall .../node_modules/@risingstack/v8-profiler
> node -e 'process.exit(0)'

> @risingstack/v8-profiler@5.7.11 install .../node_modules/@risingstack/v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://oss.risingstack.com/repo/v1/@risingstack/profiler/dist/v5.7.11/node-v64-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/v8-profiler@5.7.11 and node@10.10.0 (node-v64 ABI,unknown) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Tried to download(undefined): https://oss.risingstack.com/repo/v1/@risingstack/profiler/dist/v5.7.11/node-v64-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/v8-profiler@5.7.11 and node@10.10.0 (node-v64 ABI,unknown) (falling back to source compile with node-gyp)
  CXX(target) Release/obj.target/profiler/src/profiler.o
  CXX(target) Release/obj.target/profiler/src/profiler.o
sed: ./Release/.deps/Release/obj.target/profiler/src/profiler.o.d.raw: No such file or directory
make: *** [Release/obj.target/profiler/src/profiler.o] Error 1
gyp  CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
 ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=.../node_modules/@risingstack/v8-profiler/build/@risingstack/profiler/v5.7.11/node-v64-darwin-x64/profiler.node" "--module_name=profiler" "--module_path=.../node_modules/@risingstack/v8-profiler/build/@risingstack/profiler/v5.7.11/node-v64-darwin-x64"
gyp ERR! cwd .../node_modules/@risingstack/v8-profiler
gyp ERR! node -v v10.10.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok

@basti1302
Copy link
Contributor

Hi Ingo,

please note that @risingstack/v8-profiler is an optional dependency of the instana-nodejs-sensor, so even if it can be neither downloaded nor compiled via node-gyp (as is currently the status-quo for Node 10, unfortunately), the instana-nodejs-sensor package will actually install and work just fine. You will not be able to gather CPU profiles, but everything else will work as expected.

npm is quite chatty about failures even for optional dependencies, so that's why you see all the gyp ERR! stuff during npm install. This can be misleading.

Did your npm install actually exit with a non-zero exit code? If so, v8-profiler can't be the reason, there must be something else that has gone wrong.

Closing this for now, since the issue is more misleading than helpful.

I see you have also created a support ticket, let's continue the discussion there.

@ahtik
Copy link

ahtik commented Sep 25, 2018

CPU profiling is still a good feature of Instana and would be nice to see them supported with Node 10.

@ahtik ahtik mentioned this issue Sep 26, 2018
Closed
@basti1302
Copy link
Contributor

FWIW, we replaced the v8-profiler package with profiler bindings that work across all versions, including Node 10, so this should no longer be an issue.

willianpc added a commit that referenced this issue Apr 6, 2021
@willianpc
# This is a combination of 56 commits.
2768bb6 
# This is the 1st commit message:

Added basic test apps

# This is the commit message #2:

improved test app a little bit

# This is the commit message #3:

more refactoring; wip: process, concurrency named process in test app

# This is the commit message #4:

added consumer as process

# This is the commit message #5:

wip: in the middle of another refactoring

# This is the commit message #6:

test app covers all 12 cases

# This is the commit message #7:

started instrumentation

# This is the commit message #8:

wip: instrumenting add() function

# This is the commit message #9:

wip: dealing with repeatable jobs

# This is the commit message #10:

Using repeat with limit. avoid using cron

# This is the commit message #11:

added bulk job sending

# This is the commit message #12:

small refactoring in sender test app

# This is the commit message #13:

exit span instrumented for single and repeatable jobs

# This is the commit message #14:

wip: bulk immediate jobs

[skip ci]

# This is the commit message #15:

wip: testing the instrumentation of bulk > send job

[skip ci]

# This is the commit message #16:

complete instrumentation of exit spans

# This is the commit message #17:

docs(changelog): prepare release 1.117.0

[skip ci]

# This is the commit message #18:

v1.117.0

# This is the commit message #19:

fix: bypass native addon loading in worker threads

Co-authored-by: Willian Carvalho <willian.carvalho@instana.com>
# This is the commit message #20:

docs(changelog): prepare release 1.117.1

[skip ci]

# This is the commit message #21:

v1.117.1

# This is the commit message #22:

test(tracing): make batching test less flaky

# This is the commit message #23:

chore: add script for splitting CI output according to package

[skip ci]

# This is the commit message #24:

fix: update to shimmer@1.2.1 to be able to patch async functions

Specifically, that version includes this fix:
othiym23/shimmer@ec15ba2

# This is the commit message #25:

test(tracing): fix path for custom tags

# This is the commit message #26:

wip: added ENTRY span instrumentation

# This is the commit message #27:

renamed child process.js; removed extra execTime param from /POST; added client HTTP call

# This is the commit message #28:

immediate and repeatable jobs instrumented correctly

[skip ci]

# This is the commit message #29:

small refactoring/cleanup; [skip ci]

# This is the commit message #30:

introduced tests

[skip ci]

# This is the commit message #31:

Included test for Callback x Bulk [skip ci]

# This is the commit message #32:

wip: attempting to instrument master.js [skip ci]

# This is the commit message #33:

instrument child process with an extra entry span

# This is the commit message #34:

experimental: activate tracing immediately, without waiting for connection to agent

# This is the commit message #35:

send spans directly from Bull child process workers and wait for them to be offloaded

# This is the commit message #36:

fix linting issues

# This is the commit message #37:

Updating agent uuid from env var info

[skip ci]

# This is the commit message #38:

fixed PID casting to string [skip ci]

# This is the commit message #39:

no more IPC, write to a file instead

# This is the commit message #40:

attach trace context to each individual IPC message instead of env var at process start

# This is the commit message #41:

avoid duplicated bull entry span

# This is the commit message #42:

fixed naming convention; replaced fs/promises by fs; guarantee that opts object exists

# This is the commit message #43:

added disabled trace tests

# This is the commit message #44:

lift the requirement for applying span.disableAutoEnd/span.end()

# This is the commit message #45:

Running tests for trace disabled and suppressed

# This is the commit message #46:

all instana data is removed before customer gets the processed job data

# This is the commit message #47:

Added test to make sure no Instana data is left in Job data

# This is the commit message #48:

Added withError cases

# This is the commit message #49:

Skipping tests for Node version < 10

# This is the commit message #50:

fix(opentracing): default to type entry when no parent is referenced

# This is the commit message #51:

docs(changelog): prepare release 1.117.2

[skip ci]

# This is the commit message #52:

v1.117.2

# This is the commit message #53:

fix(metrics): register gc stats loader listener immediately

This fixes an issue where GC metrics would not be available when the
dependency gcstats.js was already present in node_modules and the
activation of the gc metrics module would happen too late.

# This is the commit message #54:

docs(changelog): prepare release 1.117.3

[skip ci]

# This is the commit message #55:

v1.117.3

# This is the commit message #56:

docs(contributing): document the need to install PostgreSQL headers

(Only required for local development.)

Plus: Additional info about rate limited OTP when publishing.

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@basti1302 @ahtik @bripkens @ingo-eichhorst