Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opts.js so agent host can be set via env var without updating application code #39

Closed
wants to merge 3 commits into from
Closed

Update opts.js so agent host can be set via env var without updating application code #39

wants to merge 3 commits into from

Conversation

s9tpepper
Copy link
Contributor

Added AGENT_HOST env var to check agent host before applying from config object

@s9tpepper
Update opts.js
22bb74a 
Added AGENT_HOST env var to check agent host before applying from config object
@pglombardo
Copy link

Thanks @s9tpepper - good suggestion. @bripkens any objections?

A couple things:

  1. 👍 env var should take priority and override any code configured settings
  2. Could you update the environment variable name to be INSTANA_AGENT_IP?
  3. We should add a similar clause for port configuration using INSTANA_AGENT_PORT

Could you make these changes and update the PR?

@s9tpepper
Copy link
Contributor Author

s9tpepper commented Mar 2, 2018 via email

@s9tpepper
apply env vars for other agent options
4b5a6ee 
- added INSTANA_AGENT_IP to configure the agent port
- added INSTANA_AGENT_NAME to configure the agent name
@s9tpepper
Copy link
Contributor Author

@pglombardo added the same env var treatment to the agent port and the agent name to keep the behavior consistent for all three agent options

@s9tpepper
Update opts.js
a04efe1 
removed trailing whitespace
@CodingFabian
Copy link
Contributor

@s9tpepper Thanks - just wanted to let you know that we are currently looking into a few things internally that we want to release as well. Thats why we did not merge this yet.
Also we might need to check if the environment variable names would conflict with others we already have. We will let you know about this shortly.
I would also like to learn why you need this, because I am currently working on a few container networking related issues. So I would appreciate if you could contact me via e-mail so we can discuss your use case and maybe the concrete problem you try to fix: fabian.lange@instana.com

@bripkens
Copy link
Contributor

bripkens commented Mar 7, 2018

Merged manually via b4b59e0 with some minor changes. Thank you very much @s9tpepper 👍 !

@bripkens bripkens closed this Mar 7, 2018
@s9tpepper
Copy link
Contributor Author

s9tpepper commented Mar 7, 2018 via email

willianpc added a commit that referenced this pull request Apr 6, 2021
@willianpc
# This is a combination of 56 commits.
2768bb6 
# This is the 1st commit message:

Added basic test apps

# This is the commit message #2:

improved test app a little bit

# This is the commit message #3:

more refactoring; wip: process, concurrency named process in test app

# This is the commit message #4:

added consumer as process

# This is the commit message #5:

wip: in the middle of another refactoring

# This is the commit message #6:

test app covers all 12 cases

# This is the commit message #7:

started instrumentation

# This is the commit message #8:

wip: instrumenting add() function

# This is the commit message #9:

wip: dealing with repeatable jobs

# This is the commit message #10:

Using repeat with limit. avoid using cron

# This is the commit message #11:

added bulk job sending

# This is the commit message #12:

small refactoring in sender test app

# This is the commit message #13:

exit span instrumented for single and repeatable jobs

# This is the commit message #14:

wip: bulk immediate jobs

[skip ci]

# This is the commit message #15:

wip: testing the instrumentation of bulk > send job

[skip ci]

# This is the commit message #16:

complete instrumentation of exit spans

# This is the commit message #17:

docs(changelog): prepare release 1.117.0

[skip ci]

# This is the commit message #18:

v1.117.0

# This is the commit message #19:

fix: bypass native addon loading in worker threads

Co-authored-by: Willian Carvalho <willian.carvalho@instana.com>
# This is the commit message #20:

docs(changelog): prepare release 1.117.1

[skip ci]

# This is the commit message #21:

v1.117.1

# This is the commit message #22:

test(tracing): make batching test less flaky

# This is the commit message #23:

chore: add script for splitting CI output according to package

[skip ci]

# This is the commit message #24:

fix: update to shimmer@1.2.1 to be able to patch async functions

Specifically, that version includes this fix:
othiym23/shimmer@ec15ba2

# This is the commit message #25:

test(tracing): fix path for custom tags

# This is the commit message #26:

wip: added ENTRY span instrumentation

# This is the commit message #27:

renamed child process.js; removed extra execTime param from /POST; added client HTTP call

# This is the commit message #28:

immediate and repeatable jobs instrumented correctly

[skip ci]

# This is the commit message #29:

small refactoring/cleanup; [skip ci]

# This is the commit message #30:

introduced tests

[skip ci]

# This is the commit message #31:

Included test for Callback x Bulk [skip ci]

# This is the commit message #32:

wip: attempting to instrument master.js [skip ci]

# This is the commit message #33:

instrument child process with an extra entry span

# This is the commit message #34:

experimental: activate tracing immediately, without waiting for connection to agent

# This is the commit message #35:

send spans directly from Bull child process workers and wait for them to be offloaded

# This is the commit message #36:

fix linting issues

# This is the commit message #37:

Updating agent uuid from env var info

[skip ci]

# This is the commit message #38:

fixed PID casting to string [skip ci]

# This is the commit message #39:

no more IPC, write to a file instead

# This is the commit message #40:

attach trace context to each individual IPC message instead of env var at process start

# This is the commit message #41:

avoid duplicated bull entry span

# This is the commit message #42:

fixed naming convention; replaced fs/promises by fs; guarantee that opts object exists

# This is the commit message #43:

added disabled trace tests

# This is the commit message #44:

lift the requirement for applying span.disableAutoEnd/span.end()

# This is the commit message #45:

Running tests for trace disabled and suppressed

# This is the commit message #46:

all instana data is removed before customer gets the processed job data

# This is the commit message #47:

Added test to make sure no Instana data is left in Job data

# This is the commit message #48:

Added withError cases

# This is the commit message #49:

Skipping tests for Node version < 10

# This is the commit message #50:

fix(opentracing): default to type entry when no parent is referenced

# This is the commit message #51:

docs(changelog): prepare release 1.117.2

[skip ci]

# This is the commit message #52:

v1.117.2

# This is the commit message #53:

fix(metrics): register gc stats loader listener immediately

This fixes an issue where GC metrics would not be available when the
dependency gcstats.js was already present in node_modules and the
activation of the gc metrics module would happen too late.

# This is the commit message #54:

docs(changelog): prepare release 1.117.3

[skip ci]

# This is the commit message #55:

v1.117.3

# This is the commit message #56:

docs(contributing): document the need to install PostgreSQL headers

(Only required for local development.)

Plus: Additional info about rate limited OTP when publishing.

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s9tpepper @pglombardo @CodingFabian @bripkens