Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Instana propagator #1

Closed
wants to merge 1 commit into from
Closed

Conversation

basti1302
Copy link

NOTE: THIS PR IS JUST FOR INTERNAL REVIEW PURPOSES. We do not intend to merge this PR into the main branch in this forked repo. Instead, we will open a PR on the upstream repository.

Which problem is this PR solving?

Short description of the changes

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@basti1302 basti1302 force-pushed the propagator-instana branch 2 times, most recently from 5206ce7 to 53499ca Compare July 5, 2022 06:22
@basti1302 basti1302 requested a review from a team July 5, 2022 06:26
@basti1302 basti1302 force-pushed the propagator-instana branch from 53499ca to 432c7fa Compare July 5, 2022 06:58
Copy link

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔋 Just left some questions :)

@basti1302 basti1302 force-pushed the propagator-instana branch 2 times, most recently from 8f093a1 to 3d23dd6 Compare July 5, 2022 14:00
@basti1302 basti1302 force-pushed the propagator-instana branch from 3d23dd6 to ad52250 Compare July 5, 2022 14:14
@basti1302
Copy link
Author

The actual PR for upstream is here now: open-telemetry#1081. Closing this as the review is completed.

@basti1302 basti1302 closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants