feat: add Instana propagator #1081
Conversation
|
|
|
This looks good to me. Please sign the CLA. Are you and @kirrg001 members of the org yet? If not, you need to become a member in order for the component owners automations to work (only org members can be assigned issues/PRs). |
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 95.91% 96.07% +0.16%
==========================================
Files 13 14 +1
Lines 857 892 +35
Branches 179 191 +12
==========================================
+ Hits 822 857 +35
Misses 35 35
|
|
Hey Daniel, thanks for the review 🙇
Yup, working on that. IBM has a corporate CLA in place, it just involves a little process and red tape to get on the list of contributors, so it might take a bit.
Not yet. I guess becoming member of the org comes after having the CLA? I'll take care of that when the CLA is in place. |
No need for a CLA specifically, but usually org membership requires you to show community engagement. Code contributions obviously require a CLA but there are non-code options as well which don't. Donating a full component that you plan to maintain probably counts as enough to gain membership though. |
basti1302
force-pushed
the
propagator-instana
branch
3 times, most recently
from
cdc5d0d to
a22158f
Compare
propagators/opentelemetry-propagator-instana/src/InstanaPropagator.ts
Outdated
Show resolved
Hide resolved
basti1302
force-pushed
the
propagator-instana
branch
from
a22158f to
e62ed81
Compare
We both have our CLA in place now. If I understood correctly, a pre-requisite to merging this would be to add both of us to the org, since our Github handles are now mentioned in |
|
@basti1302 The different level of membership are defined here: https://github.com/open-telemetry/community/blob/main/community-membership.md, you need to open an issue like this one (i can't find the template though), you can put any maintainer of us maintainers (dyladan/me for example) and link your opened PRs |
kirrg001
force-pushed
the
propagator-instana
branch
from
e62ed81 to
c14f62a
Compare
|
I'm happy to sponsor that membership |
|
Seeing the comment #1084 (review) on the resource detector PR, should I also add this component to the two release please config files? I was under the impression that release-please would automatically add entries there with the next release? |
Yes you should |
basti1302
force-pushed
the
propagator-instana
branch
from
9cc1d4b to
708acc7
Compare
kirrg001
force-pushed
the
propagator-instana
branch
from
708acc7 to
1c4f354
Compare
|
I think this would be ready to be merged. Github says it needs a review from |
basti1302
force-pushed
the
propagator-instana
branch
from
5ceff6b to
c19f4e2
Compare
|
as far as I know approvals from @open-telemetry/javascript-maintainers are also needed here. |
|
Can't merge a branch out of date with the base branch and don't have permission to update your branch |
- otherwise the build wil be broken
basti1302
force-pushed
the
propagator-instana
branch
from
c19f4e2 to
dcb04c8
Compare
|
I have rebased this now. |
|
Merging when tests pass |
Which problem is this PR solving?
Similar to the AWS X-Ray propagator, this adds a vendor specific propagator for the vendor specific trace correlation headers used by Instana.
Short description of the changes
Add Instana propagator plus unit tests.
Checklist
npm run testfor the new package on the latest commit if applicable.Remark: The CLA is not in place yet, I'm working on that (as mentioned in the other two PRs I put up recently). My thinking was that the missing CLA would not be a blocker for a review/discussion phase for this PR.