-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update publish strategy to include Ollama publishing #70
docs: Update publish strategy to include Ollama publishing #70
Conversation
31b0489
to
077b66a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!
There is some overlap with instructlab/community#198 ? Or are they unrelated? |
looks more unrelated to me. This one is about what happens when we publish new model builds (where they go, naming conventions) That other doc is more of a user doc -- how to use ollama with our models. This doc might need some updates to reflect how we publish there. Some things might be easier. I'd defer to @alinaryan on that. Either way, I think both docs make sense for different purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but otherwise LGTM
Spellcheck needs to be fixed as well |
This came up in review on instructlab#70, so document the preferred capitalization. Signed-off-by: Russell Bryant <rbryant@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one capitalization fix pending
Signed-off-by: Alina Ryan <aliryan@redhat.com>
Signed-off-by: Alina Ryan <aliryan@redhat.com>
077b66a
to
38d0d5d
Compare
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@nathan-weinberg Added a commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Add Ollama publishing scheme to the dev-docs.
Resolves #65