Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update publish strategy to include Ollama publishing #70

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

alinaryan
Copy link
Member

@alinaryan alinaryan commented May 31, 2024

Add Ollama publishing scheme to the dev-docs.

Resolves #65

@alinaryan alinaryan added the documentation Improvements or additions to documentation label May 31, 2024
@alinaryan alinaryan self-assigned this May 31, 2024
@alinaryan alinaryan force-pushed the update-publish-strat branch 2 times, most recently from 31b0489 to 077b66a Compare May 31, 2024 19:03
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@bjhargrave
Copy link
Contributor

bjhargrave commented May 31, 2024

There is some overlap with instructlab/community#198 ? Or are they unrelated?

@russellb
Copy link
Member

There is some overlap with instructlab/community#198 ? Or are they unrelated?

looks more unrelated to me. This one is about what happens when we publish new model builds (where they go, naming conventions)

That other doc is more of a user doc -- how to use ollama with our models. This doc might need some updates to reflect how we publish there. Some things might be easier. I'd defer to @alinaryan on that.

Either way, I think both docs make sense for different purposes.

Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM

@nathan-weinberg
Copy link
Member

Spellcheck needs to be fixed as well

russellb added a commit to russellb/instructlab-dev-docs that referenced this pull request May 31, 2024
This came up in review on instructlab#70, so document the preferred
capitalization.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one capitalization fix pending

alinaryan added 2 commits June 3, 2024 10:19
Signed-off-by: Alina Ryan <aliryan@redhat.com>
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan alinaryan force-pushed the update-publish-strat branch from 077b66a to 38d0d5d Compare June 3, 2024 14:20
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan
Copy link
Member Author

Spellcheck needs to be fixed as well

@nathan-weinberg Added a commit

Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nathan-weinberg nathan-weinberg merged commit 6ccd2bf into instructlab:main Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update publishing strategy to include ollama publishing
5 participants