Skip to content

Commit

Permalink
fix: improve tcpdump checker (#2600)
Browse files Browse the repository at this point in the history
Update checker to avoid false positives (e.g. with qemu)

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
  • Loading branch information
ffontaine authored Feb 1, 2023
1 parent 10afa46 commit 6cb120b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cve_bin_tool/checkers/tcpdump.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ class TcpdumpChecker(Checker):
# lookup_{emem,protoid} are static functions provided by tcpdump in addrtoname.c
VERSION_PATTERNS = [
r"tcpdump-([0-9]+\.[0-9]+\.[0-9]+)",
r"([0-9]+\.[0-9]+\.[0-9]+)\r?\n[0-9a-f]*lookup_",
r"([0-9]+\.[0-9]+\.[0-9]+)\r?\n[0-9a-f]*lookup_(?:emem|protoid)",
]
VENDOR_PRODUCT = [("tcpdump", "tcpdump")]
2 changes: 1 addition & 1 deletion test/test_data/qemu.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"package_name": "qemu-0.9.1-1.el3.rf.x86_64.rpm",
"product": "qemu",
"version": "0.9.1",
"other_products": ["gcc", "tcpdump"],
"other_products": ["gcc"],
},
{
"url": "http://ftp.fr.debian.org/debian/pool/main/q/qemu/",
Expand Down

0 comments on commit 6cb120b

Please sign in to comment.