Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve tcpdump checker #2600

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Update checker to avoid false positives (e.g. with qemu)

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

Update checker to avoid false positives (e.g. with qemu)

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2600 (f38ca3b) into main (3bb7bf9) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2600      +/-   ##
==========================================
- Coverage   82.02%   81.73%   -0.30%     
==========================================
  Files         600      600              
  Lines        9872     9872              
  Branches     1353     1353              
==========================================
- Hits         8098     8069      -29     
- Misses       1418     1449      +31     
+ Partials      356      354       -2     
Flag Coverage Δ
longtests 81.73% <ø> (+0.23%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/tcpdump.py 100.00% <ø> (ø)
test/test_data/qemu.py 100.00% <ø> (ø)
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
cve_bin_tool/extractor.py 69.02% <0.00%> (-11.51%) ⬇️
cve_bin_tool/version_scanner.py 86.95% <0.00%> (-2.49%) ⬇️
test/test_cli.py 85.81% <0.00%> (-2.13%) ⬇️
test/test_checkers.py 93.54% <0.00%> (-1.62%) ⬇️
cve_bin_tool/output_engine/__init__.py 67.85% <0.00%> (-1.08%) ⬇️
cve_bin_tool/merge.py 79.83% <0.00%> (-0.81%) ⬇️
cve_bin_tool/async_utils.py 93.79% <0.00%> (-0.69%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit 6cb120b into intel:main Feb 1, 2023
@ffontaine ffontaine deleted the fix-tcpdump-checker branch February 1, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants