Skip to content

Commit

Permalink
fix: improve icecast checker (#2545)
Browse files Browse the repository at this point in the history
* fix: improve icecast checker

xiph:icecast is a valid CPE ID

While at it, add debian and openwrt test packages

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>

* test: add other_products data to new tests

---------

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Co-authored-by: Terri Oda <terri.oda@intel.com>
  • Loading branch information
ffontaine and terriko authored Jan 25, 2023
1 parent 19ba6ed commit e2305b2
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cve_bin_tool/checkers/icecast.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
CVE checker for icecast
https://www.cvedetails.com/product/1194/Icecast-Icecast.html?vendor_id=693
https://www.cvedetails.com/product/31619/Xiph-Icecast.html?vendor_id=7966
"""
from __future__ import annotations
Expand All @@ -17,4 +18,4 @@ class IcecastChecker(Checker):
CONTAINS_PATTERNS: list[str] = []
FILENAME_PATTERNS = [r"icecast"]
VERSION_PATTERNS = [r"Icecast ([0-9]+\.[0-9]+\.[0-9]+)"]
VENDOR_PRODUCT = [("icecast", "icecast")]
VENDOR_PRODUCT = [("icecast", "icecast"), ("xiph", "icecast")]
Binary file not shown.
Binary file not shown.
14 changes: 14 additions & 0 deletions test/test_data/icecast.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,18 @@
"version": "2.4.4",
"other_products": [],
},
{
"url": "http://ftp.fr.debian.org/debian/pool/main/i/icecast2/",
"package_name": "icecast2_2.4.0-1.1+deb8u1_amd64.deb",
"product": "icecast",
"version": "2.4.0",
"other_products": [],
},
{
"url": "https://downloads.openwrt.org/releases/packages-19.07/x86_64/packages/",
"package_name": "icecast_2.4.4-1_x86_64.ipk",
"product": "icecast",
"version": "2.4.4",
"other_products": [],
},
]

0 comments on commit e2305b2

Please sign in to comment.