fix: improve icecast checker #2545
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiph:icecast is a valid CPE ID While at it, add debian and openwrt test packages Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
terriko
reviewed
Jan 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
- Coverage 82.95% 75.35% -7.61%
==========================================
Files 594 592 -2
Lines 9811 9672 -139
Branches 1344 1142 -202
==========================================
- Hits 8139 7288 -851
- Misses 1333 2077 +744
+ Partials 339 307 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
longtests fail was unrelated:
FAILED test/test_cli.py::TestCLI::test_update_flags - aiohttp.client_exceptions.ClientPayloadError: Response payload is not completed
This looks good to go and I'll merge it without waiting on a re-run, since that looks like a network error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xiph:icecastis a valid CPE IDWhile at it, add debian and openwrt test packages
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com