feat: handle : in filenames better

[terriko]

• related to feat(checker): add mp4v2 checker #4380

Windows and Linux have different filename restrictions and we recently hit a case in #4380 where the linux package name included the : character and thus windows couldn't handle it.

Now, the easy answer is "take the : out of the filename" but because of the way our condensed download tool works, it's currently using exactly the same name as the original file. (Terminology reminder: our "condensed download" files are .tar.gz files with all the strings found in a binary, typically a full linux install package, that we then use to test the vulnerabilty scanner and keep around to make sure that new checkers won't generate false positives with existing ones.)

Someone will need to go in and edit make_condensed_from_download (found in test/test_scanner.py:

cve-bin-tool/test/test_scanner.py

Line 174 in cbdff56

def make_condensed_from_download(self, download_path, condensed_path):

) so that we run a filter on filename it removes unwanted characters before making the local condensed download. That should be pretty easy. We may also need to have an identical filter where the downloads are found on disk during the testing phase.

That first part should be doable by a beginner but the latter part may be harder; I haven't looked. I'm going to mark this as a good first issue but if you get stuck let us know and I can re-evaluate if it's really beginner friendly!