Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add mp4v2 checker #4380

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Aug 23, 2024

windows_fixup must be moved to util.py to reuse this function in test_condensed_downloads.py

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on here, but windows is failing with the following error:

   Error: error: invalid path 'test/condensed-downloads/libmp4v2-1:2.1.3-2-aarch64.pkg.tar.xz.tar.gz'
  Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128

If I had to guess, the problem character in the filename is : but it could be some other windows filesystem limitation.

@ffontaine
Copy link
Contributor Author

I don't know how to fix it and unfortunately I didn't find other mp4v2 binary packages on other distributions (debian, etc.)

@terriko
Copy link
Contributor

terriko commented Aug 29, 2024

I think it'll take a change in how we build filenames from the urls in make_condensed_from_download. I believe we need to run the filename through a filter before we make/access the local file. I probably won't get to it until after the 3.4 release is done, but maybe I can file an issue or something now.

@terriko
Copy link
Contributor

terriko commented Sep 6, 2024

#4418 should have fixed this, so I'll update the branch and let the tests re-run.

@ffontaine ffontaine force-pushed the add-mp4v2-checker branch 2 times, most recently from 03e4dd5 to e4d1aa2 Compare September 7, 2024 15:29
windows_fixup must be moved to util.py to reuse this function in
test_condensed_downloads.py

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you found a new place the code was needed. Thanks!

@terriko terriko merged commit 1cb692c into intel:main Sep 9, 2024
21 checks passed
@ffontaine ffontaine deleted the add-mp4v2-checker branch September 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants