-
Notifications
You must be signed in to change notification settings - Fork 543
feat: Add ability to read CPE identifiers from CycloneDX triage data #3990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
+ Coverage 75.41% 80.31% +4.90%
==========================================
Files 808 820 +12
Lines 11983 12566 +583
Branches 1598 1706 +108
==========================================
+ Hits 9037 10093 +1056
+ Misses 2593 2041 -552
- Partials 353 432 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up that this has some merge conflicts. I'm probably not going to get to doing a code review today so if you have a chance to fix them before I get back to it, that would be much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good. I feel in my heart of hearts like there may be places in the decode functions that we could/should be doing more validation because we'll absolutely get crap data in SBOMs sometimes, but I don't see anything immediately obvious. It could also use some documentation (probably just a line saying that we support this) but in the interest of keeping things moving and getting this into the pre-release i'm hoping to have tomorrow, I'm going to go ahead and merge it as is and open a couple of issues for docs and more aggressive input validation.
This change adds functionality to extract CPE identifiers from CycloneDX triage data. These identifiers can be manually corrected if the incorrect software was identified, enabling the discovery of CVEs associated with the correct software.