[SYCL] Add tests for SYCL 2020 function objects #310
Conversation
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
maximdimakov
requested review from
AlexeySachkov,
Pennycook and
a team
as code owners
| // std::exclusive_scan isn't implemented yet, so use serial implementation | ||
| // instead |
There was a problem hiding this comment.
Now that we compile everything with C++17, can we replace this with std::exclusive_scan?
There was a problem hiding this comment.
I changed using of emu::exclusive scan to std::exclusive_scan
There was a problem hiding this comment.
It seems that Jenkins pre-ci linux/cuda compiles with c++14. Tests are failing with message "no member named 'exclusive_scan' in namespace 'std'"
There was a problem hiding this comment.
@maximdimakov, -fsycl triggers -std=c++17, so it should be compiled with c++17. Looks strange, does it reproduce locally?
There was a problem hiding this comment.
I can not reproduce this problem locally. The errors occurs when I explicitly specify -std=c++14. Without -std flag or with -std=c++17 the test passed
There was a problem hiding this comment.
Looks like the environment problem of CI machine, could be outdated libstdc++ which doesn't contain implementation for std::inclusive_scan and std::exclusive_scan. @tfzhu, can you please take a look on this issue and try to resolve it?
There was a problem hiding this comment.
Also tagging @bader to be aware about this CI problem.
There was a problem hiding this comment.
Was the problem resolved? If not, could you please leave a TODO here about using std::exclusive_scan later?
| std::numeric_limits<int>::lowest()); | ||
|
|
||
| #ifdef SPIRV_1_3 | ||
| test<class KernelName_WonwuUVPUPOTKRKIBtT>(q, input, output, |
There was a problem hiding this comment.
Please fix kernel name here as well
|
@maximdimakov, could you please fix formating issue and make sure that all test are passing as soon as compiler change was merged a while ago. |
|
FYI: name of the standard is "SYCL 2020", not "sycl2020". |
maximdimakov
changed the title
|
@vladimirlaz it seems that for linux and cuda the problem remains the same |
|
@maximdimakov, this is because of #310 (comment). Can you please contact tools team to resolve this issue? |
|
@AlexeySachkov could you please review/approve the PR? |
| // std::exclusive_scan isn't implemented yet, so use serial implementation | ||
| // instead |
There was a problem hiding this comment.
Was the problem resolved? If not, could you please leave a TODO here about using std::exclusive_scan later?
|
@AlexeySachkov could you please review/approve the PR? |
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
merge contents in BuildTest into RunTest
…e#310) Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Some tests are rewritten with SYCL2020 group algorithm functions and SYCL2020 function objects