-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL] Provide SYCL 2020 function objects #3868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
I don't think we should be importing extensions into the sycl:: namespace via aliases. There are several (subtle) ways in which a SYCL 2020 feature may differ from its ONEAPI equivalent, and we need to be very careful. Also, I think the specific algorithm you're adding here was already added as part of #3786. |
sycl::reduce_over_group was merged yesterday. The only sycl::plus is remained |
There are several other function objects that are in SYCL 2020 but are currently provided only in Minor comment: I think it makes more sense to provide |
@sergey-semenov I added functional objects accordingly to 4.17.2 point of spec. Is stl.hpp suitable for these function objects? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is stl.hpp suitable for these function objects?
I think creating sycl/functional.hpp
for these would be more appropriate.
The test in test_suite - intel/llvm-test-suite#310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Provided sycl function objects accordingly to sycl 2020 specification
The test for function objects in test_suite - intel/llvm-test-suite#310
Signed-off-by: mdimakov maxim.dimakov@intel.com