Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] string.h function test for libdevice #371

Merged
vladimirlaz merged 6 commits into from
Aug 20, 2021
Merged

[SYCL] string.h function test for libdevice #371

vladimirlaz merged 6 commits into from
Aug 20, 2021

Conversation

@jinge90
Copy link

@jinge90 jinge90 commented Jul 20, 2021

Signed-off-by: gejin ge.jin@intel.com

This PR adds test for functions in <string.h> including memcpy, memset, memcmp. Once intel/llvm#4147
is merged, this test should pass.
Thanks very much.

@jinge90 jinge90 requested a review from vzakhari as a code owner July 20, 2021 03:08
@jinge90 jinge90 mentioned this pull request Jul 20, 2021
Merged
jinge90 added 4 commits July 20, 2021 11:16
@jinge90
string.h function test for libdevice
d960da6 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Add memcmp test for unaligned address
ac5944d 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
add memory function test for different address space
71886a0 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
enhance test
7bba618 
Signed-off-by: gejin <ge.jin@intel.com>
jinge90
jinge90 commented Aug 6, 2021
View reviewed changes
SYCL/DeviceLib/string_test.cpp
dst1_acc(buffer3, cgh);
cgh.single_task<class KernelTestMemcpyAddrSpace>([=]() {
// memcpy from constant buffer to local buffer
memcpy(local_acc.get_pointer(), src_acc.get_pointer(), 8);
Copy link
Author

@jinge90 jinge90 Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @vzakhari
kernel_test_memcpy_addr_space is used to test memcpy whose input pointers have different address space. Could you help review if it meets our requirement?
Thanks very much.

vzakhari
vzakhari previously approved these changes Aug 6, 2021
View reviewed changes
@vladimirlaz
Copy link

vladimirlaz commented Aug 9, 2021

@jinge90 could you please fix clang-format issues?

vladimirlaz
vladimirlaz suggested changes Aug 16, 2021
View reviewed changes
Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinge90, could you please fix formatting issues and make sure the test is passing on all configurations?

@jinge90
Copy link
Author

jinge90 commented Aug 17, 2021

Hi, vladimirlaz
I have fixed the clang-format issue but found a lot of CUDA tests have failed. Adding a test case shouldn't impact other tests, so is there any other problem?
Thanks very much.

@vladimirlaz
Copy link

vladimirlaz commented Aug 17, 2021

Hi, vladimirlaz
I have fixed the clang-format issue but found a lot of CUDA tests have failed. Adding a test case shouldn't impact other tests, so is there any other problem?
Thanks very much.
This is known issue addressed in intel/llvm#4348.

@vladimirlaz vladimirlaz requested a review from vzakhari August 17, 2021 05:40
@vladimirlaz vladimirlaz merged commit 4c95eba into intel:intel Aug 20, 2021
@jinge90 jinge90 deleted the libdevice_test_for_string branch August 26, 2021 08:05
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@jinge90
[SYCL] string.h function test for libdevice (intel/llvm-test-suite#371)
69fc238 
Signed-off-by: gejin <ge.jin@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@vzakhari vzakhari vzakhari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinge90 @vladimirlaz @vzakhari