[SYCL][libclc] Revert signed char remangling simplications (#4207) #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
requested review from
a team,
AaronBallman,
bader,
elizabethandrews and
premanandrao
as code owners
bader
approved these changes
Aug 16, 2021
Contributor
|
@Naghasan, FYI. |
This was referenced Aug 17, 2021
Contributor
|
I'm merging this before getting approvals from code owners to fix the build of Khronos SYCL-CTS tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remangler tool introduced with #4207 also included simplifications to the use of
signed charin libclc. These simplifications changed the generated SPIRV builtins in a way that causes previously passing CTS tests to fail.This PR reverts the
signed charsimplifications, preserving the remangler and thelongsimplifications.@AerialMantis @AidanBeltonS This should not affect #4345.