Skip to content

Conversation

@pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Jun 29, 2023

This was preventing out-of-tree build of the adapter for standalone use with unified runtime.

@pbalcer pbalcer requested a review from a team as a code owner June 29, 2023 13:52
@pbalcer pbalcer requested a review from npmiller June 29, 2023 13:52
@pbalcer pbalcer force-pushed the sycl-cuda-tidy-up-namespaces branch from c1ef4be to 2890af0 Compare June 29, 2023 14:14
Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbalcer pbalcer temporarily deployed to aws June 29, 2023 15:49 — with GitHub Actions Inactive
@pbalcer pbalcer temporarily deployed to aws June 29, 2023 18:58 — with GitHub Actions Inactive
@pbalcer pbalcer force-pushed the sycl-cuda-tidy-up-namespaces branch from 2890af0 to 8ce489c Compare June 30, 2023 07:54
@pbalcer pbalcer temporarily deployed to aws June 30, 2023 09:03 — with GitHub Actions Inactive
@pbalcer pbalcer temporarily deployed to aws June 30, 2023 10:25 — with GitHub Actions Inactive
@pbalcer pbalcer force-pushed the sycl-cuda-tidy-up-namespaces branch from 8ce489c to 28bcffe Compare July 5, 2023 11:40
@pbalcer pbalcer temporarily deployed to aws July 5, 2023 11:44 — with GitHub Actions Inactive
@pbalcer pbalcer force-pushed the sycl-cuda-tidy-up-namespaces branch from 28bcffe to b153c26 Compare July 5, 2023 13:02
@pbalcer pbalcer temporarily deployed to aws July 5, 2023 14:02 — with GitHub Actions Inactive
@pbalcer pbalcer temporarily deployed to aws July 5, 2023 15:05 — with GitHub Actions Inactive
This was preventing out-of-tree build of the adapter for standalone
use with unified runtime.

Signed-off-by: Piotr Balcer <piotr.balcer@intel.com>
@pbalcer pbalcer force-pushed the sycl-cuda-tidy-up-namespaces branch from b153c26 to fd78871 Compare July 6, 2023 13:27
@pbalcer pbalcer temporarily deployed to aws July 6, 2023 13:42 — with GitHub Actions Inactive
@pbalcer pbalcer temporarily deployed to aws July 6, 2023 15:34 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor Author

pbalcer commented Jul 10, 2023

@intel/llvm-gatekeepers
Can this be merged? Thanks.

@pbalcer
Copy link
Contributor Author

pbalcer commented Jul 14, 2023

@steffenlarsen can you please take a look at this PR? I think my team mention didn't work :)

@dm-vodopyanov dm-vodopyanov changed the title [SYCL][CUDA] remove sycl dependencies from cuda ur adapter [SYCL][CUDA] Remove SYCLl dependencies from CUDA UR adapter Jul 14, 2023
@dm-vodopyanov dm-vodopyanov changed the title [SYCL][CUDA] Remove SYCLl dependencies from CUDA UR adapter [SYCL][CUDA] Remove SYCL dependencies from CUDA UR adapter Jul 14, 2023
@dm-vodopyanov dm-vodopyanov merged commit d25a336 into intel:sycl Jul 14, 2023
@steffenlarsen
Copy link
Contributor

Apologies, @pbalcer! It must have slipped through the cracks.

fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
This was preventing out-of-tree build of the adapter for standalone use
with unified runtime.

Signed-off-by: Piotr Balcer <piotr.balcer@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants