-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL][CUDA] Remove SYCL dependencies from CUDA UR adapter #10135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dm-vodopyanov
merged 1 commit into
intel:sycl
from
pbalcer:sycl-cuda-tidy-up-namespaces
Jul 14, 2023
Merged
[SYCL][CUDA] Remove SYCL dependencies from CUDA UR adapter #10135
dm-vodopyanov
merged 1 commit into
intel:sycl
from
pbalcer:sycl-cuda-tidy-up-namespaces
Jul 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1ef4be to
2890af0
Compare
npmiller
approved these changes
Jun 29, 2023
Contributor
npmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2890af0 to
8ce489c
Compare
jchlanda
approved these changes
Jun 30, 2023
8ce489c to
28bcffe
Compare
28bcffe to
b153c26
Compare
This was preventing out-of-tree build of the adapter for standalone use with unified runtime. Signed-off-by: Piotr Balcer <piotr.balcer@intel.com>
b153c26 to
fd78871
Compare
Contributor
Author
|
@intel/llvm-gatekeepers |
Contributor
Author
|
@steffenlarsen can you please take a look at this PR? I think my team mention didn't work :) |
Contributor
|
Apologies, @pbalcer! It must have slipped through the cracks. |
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
This was preventing out-of-tree build of the adapter for standalone use with unified runtime. Signed-off-by: Piotr Balcer <piotr.balcer@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing out-of-tree build of the adapter for standalone use with unified runtime.