Skip to content

Conversation

@omarahmed1111
Copy link
Contributor

@omarahmed1111 omarahmed1111 commented Jul 14, 2023

  • Fetches a newer version for intel/llvm release to include the latest UR hip adapter implementation.
  • Add build target for UR hip library.

@omarahmed1111
Copy link
Contributor Author

I fetched a newer release so source/adapters/0001-SYCL-CUDA-remove-sycl-namespaces-from-ur-adapter.patch patch should be included. but not sure if it have another use-case/requirement that prevents its deletion.

@kbenzie
Copy link
Contributor

kbenzie commented Jul 14, 2023

I fetched a newer release so source/adapters/0001-SYCL-CUDA-remove-sycl-namespaces-from-ur-adapter.patch patch should be included. but not sure if it have another use-case/requirement that prevents its deletion.

I feel like this patch file was a short term workaround so if it's no longer required I think it can be deleted. @pbalcer does that make sense?

@pbalcer
Copy link
Contributor

pbalcer commented Jul 14, 2023

I fetched a newer release so source/adapters/0001-SYCL-CUDA-remove-sycl-namespaces-from-ur-adapter.patch patch should be included. but not sure if it have another use-case/requirement that prevents its deletion.

I feel like this patch file was a short term workaround so if it's no longer required I think it can be deleted. @pbalcer does that make sense?

Unfortunately it's still needed because intel/llvm#10135 hasn't been merged yet. Is there some specific person I can ask for a merge?

Copy link
Contributor

@veselypeta veselypeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff. I'll rebase adapter specific changes on this 👍

@omarahmed1111
Copy link
Contributor Author

I fetched a newer release so source/adapters/0001-SYCL-CUDA-remove-sycl-namespaces-from-ur-adapter.patch patch should be included. but not sure if it have another use-case/requirement that prevents its deletion.

I feel like this patch file was a short term workaround so if it's no longer required I think it can be deleted. @pbalcer does that make sense?

Unfortunately it's still needed because intel/llvm#10135 hasn't been merged yet. Is there some specific person I can ask for a merge?

Ah okay, I thought it was merged already, will revert that deletion then.

@kbenzie
Copy link
Contributor

kbenzie commented Jul 14, 2023

Unfortunately it's still needed because intel/llvm#10135 hasn't been merged yet. Is there some specific person I can ask for a merge?

Looks like you have a similar situation as the hip port here, I asked @steffenlarsen then and got a quick response.

@pbalcer
Copy link
Contributor

pbalcer commented Jul 14, 2023

Looks like you have a similar situation as the hip port here, I asked @steffenlarsen then and got a quick response.

I think the team mention didn't work because I'm not a member of the intel github organization. Anyway, thanks, I'll ping Steffen.

@omarahmed1111 omarahmed1111 merged commit 4dcc3e2 into oneapi-src:adapters Jul 14, 2023
@omarahmed1111 omarahmed1111 deleted the add-hip-build-to-ur branch July 14, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants