-
Notifications
You must be signed in to change notification settings - Fork 124
[UR][HIP] Add ur hip target build #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UR][HIP] Add ur hip target build #721
Conversation
|
I fetched a newer release so |
035875c to
8a8c649
Compare
I feel like this patch file was a short term workaround so if it's no longer required I think it can be deleted. @pbalcer does that make sense? |
Unfortunately it's still needed because intel/llvm#10135 hasn't been merged yet. Is there some specific person I can ask for a merge? |
veselypeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Stuff. I'll rebase adapter specific changes on this 👍
Ah okay, I thought it was merged already, will revert that deletion then. |
8a8c649 to
40c5086
Compare
Looks like you have a similar situation as the hip port here, I asked |
I think the team mention didn't work because I'm not a member of the |
Uh oh!
There was an error while loading. Please reload this page.