[SYCL][HIP] Port HIP plugin to Unified Runtime #9617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
422daee to
c1e45e1
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
c1e45e1 to
56f738c
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
56f738c to
2a80de4
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
2a80de4 to
8f41131
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
4 times, most recently
from
dad9fa1 to
d4c1c7b
Compare
Contributor
|
looks good. |
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
d4c1c7b to
749f507
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
749f507 to
e54fb7a
Compare
omarahmed1111
force-pushed
the
hip_ur_port
branch
from
e54fb7a to
40bd3af
Compare
JackAKirk
reviewed
Jul 11, 2023
JackAKirk
approved these changes
Jul 11, 2023
Contributor
|
@jandres742 I think we might only need your approval on this PR before its ready to merge. |
jandres742
approved these changes
Jul 11, 2023
Contributor
Looks good on my side. another adapter :), great! |
jchlanda
approved these changes
Jul 12, 2023
Contributor
Author
|
@intel/llvm-gatekeepers could this be merged when possible. |
Contributor
@steffenlarsen seems like this may have slipped through the cracks yesterday, perhaps you can help us out? |
againull
pushed a commit
that referenced
this pull request
Jul 13, 2023
fixes a post commit failure for hip porting [PR](#9617) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
veselypeta
added a commit
to veselypeta/llvm
that referenced
this pull request
Sep 28, 2023
This moves the HIP plugin implementation to Unified Runtime; and changes the pi_hip plugin to use pi2ur to implement PI. The changes to the implementation have been kept to a minimum and should be functionally the same. Documentation and comments have been moved verbatim, other than changing PI references to UR. This PR is based on top of the CUDA adapter (intel#9512) so will only be ready when that is merged. --------- Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com> Co-authored-by: Petr Vesely <veselypeta@gmail.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Aaron Greig <aaron.greig@codeplay.com>
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 28, 2023
fixes a post commit failure for hip porting [PR](intel#9617) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
szadam
pushed a commit
to szadam/unified-runtime
that referenced
this pull request
Oct 13, 2023
fixes a post commit failure for hip porting [PR](intel/llvm#9617) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
omarahmed1111
added a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Oct 23, 2023
fixes a post commit failure for hip porting [PR](intel/llvm#9617) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the HIP plugin implementation to Unified Runtime; and changes the pi_hip plugin to use pi2ur to implement PI. The changes to the implementation have been kept to a minimum and should be functionally the same. Documentation and comments have been moved verbatim, other than changing PI references to UR.
This PR is based on top of the CUDA adapter (#9512) so will only be ready when that is merged.