Skip to content

[SYCL][HIP] Port HIP plugin to Unified Runtime #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenlarsen merged 50 commits into from
Jul 13, 2023
Merged

[SYCL][HIP] Port HIP plugin to Unified Runtime #9617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
94a9337
[SYCL][PI][UR][HIP] Port device, context, and platform
May 9, 2023
d9effb3
[SYCL][HIP][UR] Add setErrorMessage mechanism and remove ur_object ba…
May 18, 2023
0e3cfa9
[SYCL][HIP][UR] Add MAX_REGISTERS_PER_WORK_GROUP device query
May 18, 2023
989014d
[SYCL][HIP][UR] Port memory entry points
veselypeta May 12, 2023
9e239f7
[SYCL][PI][UR][HIP] Port usm and sampler entry-points to UR
May 16, 2023
d77d2c8
[SYCL][PI][UR][HIP] Port HIP program and kernel to Unified Runtime
May 15, 2023
cd77582
[SYCL][HIP][PI][UR] Port queue event entry points
veselypeta May 16, 2023
917faef
[SYCL][HIP][UR] change the fixup for info queries with bool return type
May 18, 2023
ea26e24
[SYCL][HIP][UR][PI] Port remaining device entry-points
May 18, 2023
ae20a70
[SYCL][HIP][UR] Port kernelSetArgMem/Sampler entry points
callumfare May 18, 2023
379100e
[SYCL][HIP][UR] Rebase pi2ur to cuda branch and remove ur_object
May 19, 2023
2870280
[SYCL][HIP][UR] Port urPlatformGetBackendOption and urGetLastResult
May 19, 2023
8a101a1
[SYLC][PI][HIP][UR] Port enqueue entry points
veselypeta May 18, 2023
9291c19
[SYCL][HIP][UR] Add urGetLastResult to common.cpp
May 19, 2023
d4ee789
[SYCL][HIP][UR] Cleanup pi_hip.cpp/.hpp
May 19, 2023
c3807dc
[SYCL][HIP][UR] Update DDI tables for enqueue entry-points
May 19, 2023
cc3a953
[SYCL][HIP][UR] Remove queue backward compatability apis
May 24, 2023
f0fb747
[SYCL][HIP][UR] Add usmPool entry points to ddi tables and fix ur*nat…
May 24, 2023
0708bcf
[SYCL][HIP][UR] Allow urKernelSetArgMemObj to set the arg to nullptr
Jun 5, 2023
043fbd2
[SYCL][HIP][UR] Change the code style to be more consistent
Jun 8, 2023
3a97424
[SYCL][UR][HIP]Add PCI_ADDRESS device info
Jun 14, 2023
ed5ca28
[SYCL][UR][HIP]fix some build warnings
Jun 14, 2023
52a0c10
[SYCL][UR][HIP]Change UR_DLLEXPORT to UR_APIEXPORT and version ur_hip
Jun 14, 2023
43e8ed4
[SYCL][UR][HIP] Small fixes for unused parameters and formating
Jun 14, 2023
c0bfd2e
[SYCL][UR][HIP] Fix a few issues in the hip adapter revealed by UR en…
aarongreig Jun 15, 2023
4ef73ef
[SYCL][UR][HIP] Mirror SYCL_PI env vars with UR prefix
callumfare Jun 19, 2023
922894e
[sycl][hip][ur] remove validation checks from inside the adapter
Jun 16, 2023
61f93db
[SYCL][UR][HIP] Fix some build warnings
Jun 20, 2023
c0e2ada
[SYCL][HIP] Fix device info return type for USM queries
callumfare Jun 21, 2023
29a8cc0
[SYCL][UR][HIP] Migrate blocking until the event is ready fuctionality
Jun 23, 2023
ea9aefe
[SYCL][UR][HIP] Update unified-runtime
Jun 23, 2023
20d5432
[SYCL][HIP][UR] Address feedback
Jun 29, 2023
4497808
Merge branch 'sycl' into hip_ur_port
Jun 29, 2023
5438314
[SYCL][HIP][UR] Change return code for unsupported context info queries
Jun 29, 2023
6d0b398
[SYCL][HIP][UR] Add pProp to kernelSet* entry-points
Jun 29, 2023
ea12dbd
[SYCL][HIP][UR] Remove sycl dependencies from hip ur adapter
Jun 29, 2023
0227f0c
Merge branch 'sycl' into hip_ur_port
Jul 3, 2023
15d9114
[SYCL][HIP][UR] Add UR headers to hip unittests
Jul 3, 2023
be65662
Merge branch 'sycl' into hip_ur_port
Jul 4, 2023
9f25afb
Merge branch 'sycl' into hip_ur_port
Jul 5, 2023
43f8edc
[SYCL][UR][HIP] Port command buffer entries
Jul 5, 2023
03a725d
Merge branch 'port_command_buffers_entries_to_ur_hip' into 'hip_ur_port'
Jul 5, 2023
2cae55a
[SYCL][UR][HIP] Ignore unused parameters in command buffer entries
Jul 5, 2023
5ad5f76
[SYCL][UR][HIP] Style fixups and add command buffers to ddi
Jul 10, 2023
bfa88db
Merge branch 'sycl' into hip_ur_port
Jul 11, 2023
9e6f796
[SYCL][UR][HIP] Add usm p2p entry points
Jul 11, 2023
743c220
[SYCL][UR][HIP] Change urUsmP2PPeerAccessGetInfoExp to return zero
Jul 11, 2023
8d7b1e8
Merge branch 'sycl' into hip_ur_port
Jul 11, 2023
c148374
Merge branch 'sycl' into hip_ur_port
Jul 13, 2023
e587f64
[SYCL][UR][HIP] remove piEnqueueNativeKernel
Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions sycl/plugins/hip/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,46 @@ set(HIP_HEADERS "${PI_HIP_INCLUDE_DIR};${PI_HIP_HSA_INCLUDE_DIR}")
# Create pi_hip library
add_sycl_plugin(hip
SOURCES
# Some code is shared with the UR adapter
"../unified_runtime/pi2ur.hpp"
"../unified_runtime/pi2ur.cpp"
"../unified_runtime/ur/ur.hpp"
"../unified_runtime/ur/ur.cpp"
"../unified_runtime/ur/adapters/hip/common.cpp"
"../unified_runtime/ur/adapters/hip/common.hpp"
"../unified_runtime/ur/adapters/hip/context.cpp"
"../unified_runtime/ur/adapters/hip/context.hpp"
"../unified_runtime/ur/adapters/hip/device.cpp"
"../unified_runtime/ur/adapters/hip/device.hpp"
"../unified_runtime/ur/adapters/hip/enqueue.cpp"
"../unified_runtime/ur/adapters/hip/event.cpp"
"../unified_runtime/ur/adapters/hip/event.hpp"
"../unified_runtime/ur/adapters/hip/platform.cpp"
"../unified_runtime/ur/adapters/hip/platform.hpp"
"../unified_runtime/ur/adapters/hip/memory.cpp"
"../unified_runtime/ur/adapters/hip/memory.hpp"
"../unified_runtime/ur/adapters/hip/sampler.cpp"
"../unified_runtime/ur/adapters/hip/sampler.hpp"
"../unified_runtime/ur/adapters/hip/usm.cpp"
"../unified_runtime/ur/adapters/hip/program.cpp"
"../unified_runtime/ur/adapters/hip/program.hpp"
"../unified_runtime/ur/adapters/hip/kernel.cpp"
"../unified_runtime/ur/adapters/hip/kernel.hpp"
"../unified_runtime/ur/adapters/hip/queue.cpp"
"../unified_runtime/ur/adapters/hip/queue.hpp"
"../unified_runtime/ur/adapters/hip/command_buffer.cpp"
"../unified_runtime/ur/adapters/hip/command_buffer.hpp"
"../unified_runtime/ur/adapters/hip/usm_p2p.cpp"
"../unified_runtime/ur/adapters/hip/ur_interface_loader.cpp"
"${sycl_inc_dir}/sycl/detail/pi.h"
"${sycl_inc_dir}/sycl/detail/pi.hpp"
"pi_hip.hpp"
"pi_hip.cpp"
INCLUDE_DIRS
${sycl_plugin_dir}
${CMAKE_CURRENT_SOURCE_DIR}/../unified_runtime
LIBRARIES
UnifiedRuntime-Headers
HEADER
${CMAKE_CURRENT_SOURCE_DIR}/include/features.hpp
)
Expand Down
Loading