[CI] Use single reusable workflow for E2E tests on Linux #10292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow will be shared between normal "Build + E2E" and "E2E on Nightly" tasks.
Contributor
Author
|
Tested in |
| image: ${{ matrix.image }} | ||
| image_options: --device=/dev/dri --privileged --cap-add SYS_ADMIN ${{ matrix.extra_image_opts }} | ||
| extra_cmake_args: ${{ matrix.extra_cmake_args }} | ||
| extra_image_opts: ${{ matrix.extra_image_opts }} |
Contributor
There was a problem hiding this comment.
are we using extra_image_opts someplace else? I thought -u 1001 was required for some reason that I can't remember ( same user as when containers are created? )
Contributor
Author
There was a problem hiding this comment.
Resolved offline.
cperkinsintel
approved these changes
Jul 11, 2023
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
This looks good. I had a question about extra_cmake_opts ( as opposed to extra_cmake_args ), but if that's no issue, then proceed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow will be shared between normal "Build + E2E" and "E2E on Nightly" tasks.