-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL][CUDA] Implement ext_oneapi_queue_priority #11297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The E2E test assumes that the device supports priorities (sm_35 or newer).
gmlueck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec changes OK.
npmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@kbenzie | @smaslov-intel - Can me go ahead with review and merge of the adapter changes? |
We have pulled the CUDA adapter source over to the UR repo already in oneapi-src/unified-runtime#896. #11342 is in progress although its unclear when it will be ready to merge. Soon hopefully, review and GitHub Actions pending. We can pull over any additional changes to the CUDA adapter source to the UR repo which merges before #11342. I think that's probably the smoothest path forwards in this case if this is ready to go. |
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you, @kbenzie ! Let us try and follow that path. |
|
I also have plans for doing the same thing with HIP. Would it be better to wait until #11343 and oneapi-src/unified-runtime#903 land, and then do open the pull request to the UR repo? |
@al42and yes, that would be ideal, thanks. We plan to move the adapters ASAP. There is a contribtion guide, specifically relevant in this case is the Adpater Change Process. @steffenlarsen this looks like its ready to merge now. |
The E2E test assumes that the device supports priorities (sm_35 or newer).