Skip to content

[HIP][UR] Remove hip adapter source code from intel/llvm #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 4 commits into from
Oct 9, 2023
Merged

[HIP][UR] Remove hip adapter source code from intel/llvm #11343

steffenlarsen merged 4 commits into from
Oct 9, 2023

Conversation

@veselypeta
Copy link
Contributor

@veselypeta veselypeta commented Sep 28, 2023 •
edited
Loading

Removes the adapter code for the HIP plugin which is now available as part of unified runtime as part of oneapi-src/unified-runtime#903

@veselypeta veselypeta closed this Sep 28, 2023
@veselypeta veselypeta reopened this Sep 28, 2023
@veselypeta
Copy link
Contributor Author

veselypeta commented Sep 28, 2023 •
edited
Loading

Do not merge until oneapi-src/unified-runtime#903 is merged.
Can now be merged 👍

@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 04ccb0d to 01f6473 Compare September 28, 2023 14:24
@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 01f6473 to 9e680db Compare September 28, 2023 14:46
@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 9e680db to 7b81c2e Compare September 28, 2023 15:01
@veselypeta veselypeta temporarily deployed to WindowsCILock September 28, 2023 15:02 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock September 28, 2023 15:25 — with GitHub Actions Inactive
@al42and al42and mentioned this pull request Sep 29, 2023
Merged
@veselypeta veselypeta marked this pull request as ready for review October 2, 2023 14:37
@veselypeta veselypeta requested review from a team as code owners October 2, 2023 14:37
@veselypeta veselypeta requested a review from npmiller October 2, 2023 14:37
@veselypeta veselypeta temporarily deployed to WindowsCILock October 2, 2023 14:37 — with GitHub Actions Inactive
@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 15f6446 to 03da743 Compare October 2, 2023 14:37
@veselypeta veselypeta temporarily deployed to WindowsCILock October 2, 2023 14:38 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 2, 2023 15:02 — with GitHub Actions Inactive
@veselypeta veselypeta closed this Oct 2, 2023
@veselypeta
Copy link
Contributor Author

veselypeta commented Oct 2, 2023

Re running ci

@veselypeta veselypeta reopened this Oct 2, 2023
@veselypeta veselypeta temporarily deployed to WindowsCILock October 2, 2023 18:26 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 2, 2023 18:53 — with GitHub Actions Inactive
@veselypeta veselypeta closed this Oct 3, 2023
@veselypeta veselypeta reopened this Oct 3, 2023
@veselypeta veselypeta temporarily deployed to WindowsCILock October 3, 2023 07:48 — with GitHub Actions Inactive
@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 03da743 to 84b4427 Compare October 3, 2023 08:00
@veselypeta veselypeta temporarily deployed to WindowsCILock October 3, 2023 08:01 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 3, 2023 08:22 — with GitHub Actions Inactive
@veselypeta veselypeta force-pushed the petr/remove_hip_adapter_sources branch from 84b4427 to 2cef460 Compare October 5, 2023 08:56
@veselypeta veselypeta temporarily deployed to WindowsCILock October 5, 2023 08:57 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 5, 2023 09:18 — with GitHub Actions Inactive
@veselypeta
Copy link
Contributor Author

veselypeta commented Oct 5, 2023 •
edited
Loading

Please wait for #11342 to merge.

@veselypeta veselypeta temporarily deployed to WindowsCILock October 6, 2023 08:47 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 6, 2023 09:08 — with GitHub Actions Inactive
@veselypeta
Copy link
Contributor Author

veselypeta commented Oct 6, 2023

@intel/dpcpp-l0-pi-reviewers @intel/llvm-reviewers-cuda Can you please review and merge?

@steffenlarsen steffenlarsen merged commit 7812fa9 into intel:sycl Oct 9, 2023
@veselypeta veselypeta deleted the petr/remove_hip_adapter_sources branch October 9, 2023 14:27
jsji
jsji reviewed Oct 10, 2023
View reviewed changes
sycl/plugins/unified_runtime/CMakeLists.txt

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
set(UNIFIED_RUNTIME_TAG b38855ed815ffd076bfde5e5e06170ca4f723dc1)
set(UNIFIED_RUNTIME_TAG e6343f4cca9a37b17bc63f3a81968ac3f486be8a)
Copy link
Contributor

@jsji jsji Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we want to rollback UR tag here?

* |   b38855e - (2023-10-05) Merge pull request #920 from jsji/localcopy - Piotr Balcer
|\ \
| * | 6a2c548 - (2023-10-02) [UR][L0] Copy prebuilt L0 to avoid leaking shared folder path - Jinsong Ji (localcopy)
|/ /
* |   e6343f4 - (2023-10-04) Merge pull request #923 from pbalcer/l0-win-fix-build - Piotr Balcer

@jsji jsji mentioned this pull request Oct 11, 2023
Merged
againull pushed a commit that referenced this pull request Oct 12, 2023
@jsji
[UR] Fix accidentally rollback in 7812fa9 (#11503)
6f911ff 
We have updated UR after #11343 was
posted,
However, when the PR was merged, it accidentally rollbacked UR.

This is to fix the rollback and also added comments in CMakeLists.txt to
help avoiding future accidental rollback.
@kbenzie kbenzie mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsji jsji jsji left review comments

+5 more reviewers

@npmiller npmiller npmiller approved these changes

@Seanst98 Seanst98 Seanst98 approved these changes

@isaacault isaacault isaacault approved these changes

@przemektmalon przemektmalon przemektmalon approved these changes

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@veselypeta @jsji @npmiller @Seanst98 @isaacault @przemektmalon @smaslov-intel @steffenlarsen