[UR] Fix accidentally rollback in 7812fa95e2c #11503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have updated UR after #11343 was posted, However, when the PR was merged, it accidentally rollbacked UR. This is to fix the rollback and also added comments in CMakeLists.txt to help avoiding future accidental rollback.
jsji
changed the title
Contributor
|
That's unfortunate. I'm wondering about ways we might be able to avoid this in future. Perhaps with scripting and a github action check? Or perhaps there should be a defined process for updating the UR tag which is enforced by codeowners? |
Contributor
Author
Yes, some script to validate the given hash would be great. |
Contributor
Author
|
@intel/dpcpp-l0-pi-reviewers Can you please have a look? Thanks! |
againull
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have updated UR after #11343 was posted,
However, when the PR was merged, it accidentally rollbacked UR.
This is to fix the rollback and also added comments in CMakeLists.txt to
help avoiding future accidental rollback.