-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL][Graph] fix the address pointer in graph print #13595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbb46ed to
1e38240
Compare
b1529be to
8d5c034
Compare
8d5c034 to
926050c
Compare
|
hi, I don't think the ci failure (copy below) is caused by this PR. Run cmake -GNinja -B./build-e2e -S./llvm/sycl/test-e2e -DSYCL_TEST_E2E_TARGETS="ext_oneapi_hip:gpu" -DCMAKE_CXX_COMPILER="$(which clang++)" -DLLVM_LIT="$PWD/llvm/llvm/utils/lit/lit.py" -DHIP_PLATFORM="AMD" -DAMD_ARCH="gfx1031" is not able to compile a simple test program. It fails with the following output: CMake will not be able to correctly generate this project. -- Configuring incomplete, errors occurred! |
EwanC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think that HIP CI fail will go away if you merge in tip sycl branch.
the address pointer should be the USM pointer
926050c to
e86d9ef
Compare
|
ping for merge |
|
@intel/llvm-gatekeepers This is ready to merge |
|
Sorry this was missed. The testing results are fairly old. @guoyejun - Could you please push a merge commit to retrigger testing and ping me or the gatekeepers when it passes? |
|
@steffenlarsen all tests are passed, thanks. |
the address pointer should be the USM pointer
the address pointer should be the USM pointer