Skip to content

Conversation

@guoyejun
Copy link
Contributor

the address pointer should be the USM pointer

@guoyejun guoyejun requested a review from a team as a code owner April 30, 2024 06:47
@guoyejun guoyejun force-pushed the graph_print_pointer branch from dbb46ed to 1e38240 Compare April 30, 2024 06:56
@guoyejun guoyejun force-pushed the graph_print_pointer branch 2 times, most recently from b1529be to 8d5c034 Compare April 30, 2024 07:53
@guoyejun guoyejun force-pushed the graph_print_pointer branch from 8d5c034 to 926050c Compare May 1, 2024 13:45
@guoyejun guoyejun temporarily deployed to WindowsCILock May 1, 2024 14:13 — with GitHub Actions Inactive
@guoyejun guoyejun temporarily deployed to WindowsCILock May 1, 2024 15:29 — with GitHub Actions Inactive
@guoyejun
Copy link
Contributor Author

guoyejun commented May 3, 2024

hi, I don't think the ci failure (copy below) is caused by this PR.

Run cmake -GNinja -B./build-e2e -S./llvm/sycl/test-e2e -DSYCL_TEST_E2E_TARGETS="ext_oneapi_hip:gpu" -DCMAKE_CXX_COMPILER="$(which clang++)" -DLLVM_LIT="$PWD/llvm/llvm/utils/lit/lit.py" -DHIP_PLATFORM="AMD" -DAMD_ARCH="gfx1031"
Configuring SYCL End-to-End Tests
-- The CXX compiler identification is Clang 19.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - failed
-- Check for working CXX compiler: /__w/llvm/llvm/toolchain/bin//clang++
-- Check for working CXX compiler: /__w/llvm/llvm/toolchain/bin//clang++ - broken
CMake Error at /usr/share/cmake-3.22/Modules/CMakeTestCXXCompiler.cmake:62 (message):
The C++ compiler

"/__w/llvm/llvm/toolchain/bin//clang++"

is not able to compile a simple test program.

It fails with the following output:

Change Dir: /__w/llvm/llvm/build-e2e/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_03[10](https://github.com/intel/llvm/actions/runs/8910147026/job/24470383583?pr=13595#step:20:11)6 && [1/2] Building CXX object CMakeFiles/cmTC_03106.dir/testCXXCompiler.cxx.o
[2/2] Linking CXX executable cmTC_03106
FAILED: cmTC_03106 
: && /__w/llvm/llvm/toolchain/bin//clang++   CMakeFiles/cmTC_03106.dir/testCXXCompiler.cxx.o -o cmTC_03106   && :
/usr/bin/ld: cannot find -lstdc++: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:6 (project)

-- Configuring incomplete, errors occurred!
See also "/__w/llvm/llvm/build-e2e/CMakeFiles/CMakeOutput.log".
See also "/__w/llvm/llvm/build-e2e/CMakeFiles/CMakeError.log".
Error: Process completed with exit code 1.

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that HIP CI fail will go away if you merge in tip sycl branch.

the address pointer should be the USM pointer
@guoyejun guoyejun force-pushed the graph_print_pointer branch from 926050c to e86d9ef Compare May 4, 2024 04:24
@guoyejun guoyejun temporarily deployed to WindowsCILock May 4, 2024 04:24 — with GitHub Actions Inactive
@guoyejun guoyejun temporarily deployed to WindowsCILock May 4, 2024 04:51 — with GitHub Actions Inactive
@guoyejun
Copy link
Contributor Author

ping for merge

@EwanC
Copy link
Contributor

EwanC commented Jun 6, 2024

@intel/llvm-gatekeepers This is ready to merge

@steffenlarsen
Copy link
Contributor

Sorry this was missed. The testing results are fairly old. @guoyejun - Could you please push a merge commit to retrigger testing and ping me or the gatekeepers when it passes?

@steffenlarsen
Copy link
Contributor

@guoyejun - Beware that the CUDA CI is currently broken and is expected to be fixed with #14074. A new merge commit may be needed once it is merged.

@guoyejun
Copy link
Contributor Author

guoyejun commented Jun 8, 2024

@steffenlarsen all tests are passed, thanks.

@steffenlarsen steffenlarsen merged commit a35f862 into intel:sycl Jun 10, 2024
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
the address pointer should be the USM pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants